-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT Run] [Time and Date] Unix Time in milliseconds, fix negative unix time input, error message improvement #29149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htcfreek
added
Idea-Enhancement
New feature or request on an existing product
Run-Plugin
Things that relate with PowerToys Run's plugin interface
labels
Oct 11, 2023
The user docs doesn't mention the available formats. So there is no need to update them. |
This comment has been minimized.
This comment has been minimized.
htcfreek
added
the
Needs-Review
This Pull Request awaits the review of a maintainer.
label
Oct 11, 2023
htcfreek
changed the title
[PT Run] [Time and Date] Support for Unix Time in milliseconds
[PT Run] [Time and Date] Unix Time in milliseconds, fix negative unix time input
Oct 12, 2023
This comment has been minimized.
This comment has been minimized.
htcfreek
changed the title
[PT Run] [Time and Date] Unix Time in milliseconds, fix negative unix time input
[PT Run] [Time and Date] Unix Time in milliseconds, fix negative unix time input, error message improvement
Oct 12, 2023
Now this PR is definitely ready for review. |
jaimecbernardo
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Idea-Enhancement
New feature or request on an existing product
Needs-Review
This Pull Request awaits the review of a maintainer.
Run-Plugin
Things that relate with PowerToys Run's plugin interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The PR adds
And this PR fixes
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Build and tested locally.