Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT Run] [Time and Date] Unix Time in milliseconds, fix negative unix time input, error message improvement #29149

Merged
merged 10 commits into from
Oct 18, 2023

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Oct 11, 2023

Summary of the Pull Request

The PR adds

  • a result for Unix Time in milliseconds.
  • support for parsing Unix Time in milliseconds.

And this PR fixes

  • parsing of negative UNIX epoch time input.
  • number parsing error is not shown when searching for a specific result.

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • Additional a tool tip is added to the error result for people with big font sizes / dpi scaling.
  • And the regex for parsing special number inputs is improved.

Validation Steps Performed

Build and tested locally.

@htcfreek htcfreek self-assigned this Oct 11, 2023
@htcfreek htcfreek added Idea-Enhancement New feature or request on an existing product Run-Plugin Things that relate with PowerToys Run's plugin interface labels Oct 11, 2023
@htcfreek
Copy link
Collaborator Author

The user docs doesn't mention the available formats. So there is no need to update them.

@github-actions

This comment has been minimized.

@htcfreek htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Oct 11, 2023
@htcfreek htcfreek marked this pull request as draft October 12, 2023 16:43
@htcfreek htcfreek changed the title [PT Run] [Time and Date] Support for Unix Time in milliseconds [PT Run] [Time and Date] Unix Time in milliseconds, fix negative unix time input Oct 12, 2023
@github-actions

This comment has been minimized.

@htcfreek htcfreek marked this pull request as ready for review October 12, 2023 18:46
@htcfreek htcfreek changed the title [PT Run] [Time and Date] Unix Time in milliseconds, fix negative unix time input [PT Run] [Time and Date] Unix Time in milliseconds, fix negative unix time input, error message improvement Oct 12, 2023
@htcfreek
Copy link
Collaborator Author

Now this PR is definitely ready for review.

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit 50cb279 into microsoft:main Oct 18, 2023
@htcfreek htcfreek deleted the PT_UnixMs branch October 18, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea-Enhancement New feature or request on an existing product Needs-Review This Pull Request awaits the review of a maintainer. Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants