Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FancyZones] Filtering popup windows - follow up PR #28975

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

SeraphimaZykova
Copy link
Collaborator

Summary of the Pull Request

Follow-up for #28956.
Removing temporary solution for the hotfix, and updating the generally used filter of processable windows.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Oct 11, 2023
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have a code nit. WDYT?

Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>
@jaimecbernardo
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jaimecbernardo jaimecbernardo merged commit 1b333df into microsoft:main Oct 12, 2023
@SeraphimaZykova SeraphimaZykova deleted the fz-popup-followup branch October 13, 2023 12:02
jaimecbernardo added a commit that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants