[PowerRename] Handle many items w/o crashing and OOM

[yuyoyuppe]

Summary of the Pull Request

PowerRename.100K.ListView.mp4

• Introduce proxy collection for shell items
• Make sure virtualization works for ListView
• Disable AnimatedIcon for CheckBox

PR Checklist

• Closes: [PowerRename] Crashes when there are many files #18478, PowerRename (still) can't handle large folders/many files #17656
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

1. Isolating the issue showed that using the following XAML instead of the current PowerRename's ExplorerItems was still crashing when scrolling with 1K+ items:

        <ListView.ItemTemplate>
            <DataTemplate>
                <CheckBox />
            </DataTemplate>
        </ListView.ItemTemplate>

So, simply using WinUI's CheckBox causes the app to crash, as was noted previously. Using a DataTemplate with a CheckBox instead of wrapping it in a UserControl makes the behavior much better, but it's still possible to crash it.

Another issue is that the scrolling starts to slow down and end up unusable. Sampling the call stack shows it happens somewhere in the DirectComposition layer:

>	Microsoft::UI::Composition::AnimationBindingManager::UnregisterAllAnimationTargets()	Unknown
 	Microsoft::UI::Composition::Visual::Destroy(void)	Unknown
 	Microsoft::WRL2::ContextRuntimeClass::ProcessDestroyWorkflow(bool,bool *)	Unknown
 	Microsoft::UI::Composition::VisualCommon::CleanUpAllChildren(void)	Unknown
 	Microsoft::UI::Composition::Visual::Destroy(void)	Unknown

Inspecting Live Visual Tree has shown that UI virtualization is also active: the number of ListViewItems doesn't grow beyond a certain number. Explicitly setting VirtualizingStackPanel as a ListView.ItemsPanel didn't make a difference.

2. By copying the style directly into PowerRename App.xaml's resources it's evident that the element that's causing that is <animatedVisuals:AnimatedAcceptVisualSource /> of AnimatedIcon, i.e. the check mark icon.

Looking at the docs, we can find the line responsible for not using animation, but it doesn't make a difference when turning off the animations (Accessibility -> Visual Effects -> Animation effects). I haven't found a way to force Fallback animation, so I've removed the AnimatedIcon by overriding CheckBox's Style and filed an issue in WinUI repo.

3. Now, trying to add many items using DEBUG_BENCHMARK_100K_ENTRIES resulted in an OOM on my system, because each element of vec<ExplorerItem> is a UserControl, thus ExplorerItemsSource and ExplorerItemViewModel were implemented to support data virtualization and is essentially a proxy to IPowerRenameManager's items.

4. For some reason, x:Bind doesn't work in the context of DataTemplate when binding ExplorerItem's properties to ExplorerItemViewModel's properties with the same name, so I've added VM suffices to the property names accordingly.

5. Using parallel std::sort increased startup performance from 80seconds to 30seconds.

6. OnAdded and OnUpdated events are no longer needed anymore, as well as ExplorerItemsMap.

Validation Steps Performed

• 100K test
• full checklist

[yuyoyuppe]

Ready for review. Supports up to 100K entries on my machine w/o issues.

[stefansjfw]

I still see issues on "Only show items that will be renamed" view on scrolling. All renamable items end up in the same depth, i.e. folders are lost

[yuyoyuppe]

Ready for review. After internal discussion, we've decided to move forward with Standard VirtualizationMode for now.

[SeraphimaZykova]

Tested on ARM, it works stable and not crashing on a significant amount of files.

[jaimecbernardo]

After starting from a clean start (Delete "%localappdata%\Microsoft\PowerToys"), it shows no files when selecting a 10000 file folder I was testing with:

Can we default to showing some files as the default, like before? This will be a bad default experience as users won't understand what's going on.

[stefansjfw]

After starting from a clean start (Delete "%localappdata%\Microsoft\PowerToys"), it shows no files when selecting a 10000 file folder I was testing with: Can we default to showing some files as the default, like before? This will be a bad default experience as users won't understand what's going on.

Was it with DEBUG_BENCHMARK_100K_ENTRIES enabled or triggering from context menu?

[stefansjfw]

After starting from a clean start (Delete "%localappdata%\Microsoft\PowerToys"), it shows no files when selecting a 10000 file folder I was testing with: Can we default to showing some files as the default, like before? This will be a bad default experience as users won't understand what's going on.

Was it with DEBUG_BENCHMARK_100K_ENTRIES enabled or triggering from context menu?

yeah, I can reproduce this after installing powertoys

[yuyoyuppe]

@jaimecbernardo nice catch, fixed!

[stefansjfw]

Overall, it looks good. There are few things discussed privately that could be investigated to improve performance. Ok to have those as separate PRs.

For this one, let's just fix showing directory structure of Show only files that will be renamed view.

[stefansjfw]

very nice! :)

[jaimecbernardo]

Tested and works as expected. Thank you!

[SeraphimaZykova]

Tested, works nicely!