Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FancyZones][Hotfix] Fix VirtualDesktopManager init #14793

Merged

Conversation

SeraphimaZykova
Copy link
Collaborator

Summary of the Pull Request

What is this about:

  • Changed IVirtualDesktopManager initialization
  • Added missed nullptr check

What is include in the PR:

How does someone test / validate:

  • Launch PT, verify that FZ works.
  • Verify that no [error] Failed to create VirtualDesktopManager instance in the logs.

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@franky920920
Copy link
Contributor

Shipping with v0.51.1?

@franky920920 franky920920 added the Hot Fix Items we will product an out-of-band release for label Dec 3, 2021
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Great work!

@jaimecbernardo
Copy link
Collaborator

Shipping with v0.51.1?

That's the idea ;)

@SeraphimaZykova SeraphimaZykova merged commit 9d10426 into microsoft:main Dec 3, 2021
@SeraphimaZykova SeraphimaZykova deleted the 13214-fancy-zones-crash branch December 3, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hot Fix Items we will product an out-of-band release for
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants