-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview pane toggle instructions #14595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@dedavis6797 Minor nit: since we already have so many warnings on this page, you could consider replacing the InfoBar with a plain TextBlock (as this can also just be a general instruction on how to enable this). We do something similar for mouse utilities: For that, you can replace the <InfoBar .... at line 34 with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@dedavis6797 |
Should we switch the reboot info to secondary text too? I don't think it is as such important. This would make ux more consistent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small text adjustment.
src/settings-ui/Microsoft.PowerToys.Settings.UI/Strings/en-us/Resources.resw
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…Resources.resw Co-authored-by: Heiko <61519853+htcfreek@users.noreply.github.com>
Summary of the Pull Request
What is this about:
Adding text to the File Explorer settings menu explaining how to enable preview pane.
What is include in the PR:
New information block in File Explorer settings menu
How does someone test / validate:
Ensure localized translation is correct. Currently broken as we transition our build pipeline.
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.