Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview pane toggle instructions #14595

Merged
merged 4 commits into from
Nov 26, 2021
Merged

Conversation

dedavis6797
Copy link
Contributor

Summary of the Pull Request

What is this about:
Adding text to the File Explorer settings menu explaining how to enable preview pane.

What is include in the PR:
New information block in File Explorer settings menu

How does someone test / validate:
Ensure localized translation is correct. Currently broken as we transition our build pipeline.

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

Copy link
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niels9001
Copy link
Contributor

niels9001 commented Nov 23, 2021

@dedavis6797 Minor nit: since we already have so many warnings on this page, you could consider replacing the InfoBar with a plain TextBlock (as this can also just be a general instruction on how to enable this). We do something similar for mouse utilities:

image

For that, you can replace the <InfoBar .... at line 34 with:

Copy link
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@htcfreek
Copy link
Collaborator

@dedavis6797
Can you please upload a screenshot with admin mode and one without it.

@dedavis6797
Copy link
Contributor Author

@htcfreek

image

image

@htcfreek
Copy link
Collaborator

Should we switch the reboot info to secondary text too? I don't think it is as such important. This would make ux more consistent.

Copy link
Collaborator

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small text adjustment.

@crutkas
Copy link
Member

crutkas commented Nov 23, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…Resources.resw

Co-authored-by: Heiko <61519853+htcfreek@users.noreply.github.com>
@niels9001 niels9001 merged commit 991124c into main Nov 26, 2021
@niels9001 niels9001 deleted the PreviewPaneToggleInstructions branch November 26, 2021 14:00
@Jay-o-Way Jay-o-Way added the Product-File Explorer Power Toys that touch explorer like Preview Pane label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-File Explorer Power Toys that touch explorer like Preview Pane
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants