Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT Run] Support for application URI #14391

Merged
merged 10 commits into from
Nov 16, 2021
Merged

Conversation

franky920920
Copy link
Contributor

@franky920920 franky920920 commented Nov 12, 2021

Summary of the Pull Request

What is this about:
Support for application URI.

What is include in the PR:

  • Changes to URI parser.
  • Icon for URI plugin changed

How does someone test / validate:
Try typing different URI into PT run or the test case is added the tests can be performed by the unit tests.

Known issues (May needs to be added to docs)

Quality Checklist

  • Linked issue: [Run] Empty protocol handlers  #14015
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@franky920920
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 14391 in repo microsoft/PowerToys

@crutkas
Copy link
Member

crutkas commented Nov 12, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@davidegiacometti davidegiacometti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected.

Icon for dark theme is bigger than the light one:
image
image

@franky920920
Copy link
Contributor Author

Icon for dark theme is bigger than the light one:

image

image

Hmm... Interesting. I've just convert the svgs to pngs. I'll crop them to match the size. :)

@franky920920
Copy link
Contributor Author

@davidegiacometti Cloud you commit this image to .\src\modules\launcher\Plugins\Microsoft.Plugin.Uri\Images\uri.light.png on this branch? Thanks!
uri light

@jaimecbernardo
Copy link
Collaborator

@davidegiacometti Cloud you commit this image to .\src\modules\launcher\Plugins\Microsoft.Plugin.Uri\Images\uri.light.png on this branch? Thanks! uri light

Hi @franky920920 ,
Could you please send it in a zip? Just to avoid any changes to the image by GitHub.

@franky920920
Copy link
Contributor Author

@jaimecbernardo / @davidegiacometti Here: uri.light.zip 😄

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you for the contribution!

@davidegiacometti
Copy link
Collaborator

Thanks @jaimecbernardo
LGTM! Thank you!

@jaimecbernardo jaimecbernardo merged commit c934127 into main Nov 16, 2021
@crutkas crutkas deleted the feature/ptrun_application_uri branch November 19, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants