-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT Run] Support for application URI #14391
Conversation
/azp run |
Commenter does not have sufficient privileges for PR 14391 in repo microsoft/PowerToys |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidegiacometti Cloud you commit this image to |
Hi @franky920920 , |
@jaimecbernardo / @davidegiacometti Here: uri.light.zip 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for the contribution!
Thanks @jaimecbernardo |
Summary of the Pull Request
What is this about:
Support for application URI.
What is include in the PR:
How does someone test / validate:
Try typing different URI into PT run or the test case is added the tests can be performed by the unit tests.
Known issues (May needs to be added to docs)
domain:port
(example.com:443
) is parsed as the application URI and won't be opened by the browser. ( Web links not suport with port numbers #14260)Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.