Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ColorPicker] Fix contrast issue #13450

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Conversation

niels9001
Copy link
Contributor

Summary of the Pull Request

#11987 #11986 - Minor tweaks in opacity so the font color meets accessibility requirements.
image

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@dedavis6797
Copy link
Contributor

@jaimecbernardo can we get this into the Stable branch today?

Copy link
Collaborator

@stefansjfw stefansjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Accessibility Insights For Windows, color ratios are good now

@jaimecbernardo jaimecbernardo merged commit bc7d1bc into master Sep 27, 2021
@dedavis6797
Copy link
Contributor

Perfect! Let me know once this is in the stable branch I'll kick off a new test build.

@jaimecbernardo
Copy link
Collaborator

@niels9001 ,
Thank you for the contribution!

@jaimecbernardo
Copy link
Collaborator

Perfect! Let me know once this is in the stable branch I'll kick off a new test build.

Getting some more fixes in, as well.

@niels9001 niels9001 deleted the users/niels9001/cp-colorfix branch September 27, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants