Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ColorPicker] Accessibility: Close only flyout with escape key #12441

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

What is this about:
When the escape key is pressed in the Color Picker editor, only the adjust color flyout should be closed instead of the whole window.

What is include in the PR:
Some code blocking the global key event hook from processing the escape key if the flyout is open.
Also some code to end the current session before starting a new one if the user presses the shortcut again.

How does someone test / validate:
Press the escape key when the flyout is open.

Quality Checklist

When the escape key is pressed in the Color Picker editor, only the
adjust color flyout should be closed instead of the whole window.
@niels9001
Copy link
Contributor

@jaimecbernardo FYI, I think you can reuse a lot of this PR's code to fix: #12093

Same issue, just for FancyZones

@jaimecbernardo
Copy link
Collaborator Author

@niels9001 ,
Thanks for the review and the heads up.
I think #12093 is a bit different. There's the issue of making tooltips dismissable through the use of the Escape key.

Copy link
Contributor

@mykhailopylyp mykhailopylyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Created an issue to track repetitive press behavior. #12519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants