Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PowerToys awake to translation issue template. #12160

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

Aaron-Junker
Copy link
Collaborator

@Aaron-Junker Aaron-Junker commented Jul 2, 2021

Summary of the Pull Request

What is include in the PR:
Added PowerToys Awake in the list of options for the translation issue template

How does someone test / validate:
Create an translation issue

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@Aaron-Junker Aaron-Junker requested a review from dedavis6797 July 2, 2021 14:51
@Aaron-Junker
Copy link
Collaborator Author

Aaron-Junker commented Aug 22, 2021

@crutkas @dedavis6797 Can we merge this please?

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaimecbernardo
Copy link
Collaborator

@Aaron-Junker ,
It looks like the tests are failing but I'm unable to re-run these tests, since they were run long ago.
Could you perhaps rebase the PR in top of current master and force push it to trigger another test run?
Thank you!

@Aaron-Junker
Copy link
Collaborator Author

@jaimecbernardo Does it work now?

@jaimecbernardo
Copy link
Collaborator

Yes, perfect. Thank you!

@jaimecbernardo jaimecbernardo merged commit c125cc2 into microsoft:master Aug 23, 2021
@Aaron-Junker Aaron-Junker deleted the patch-10 branch August 23, 2021 17:11
@Aaron-Junker
Copy link
Collaborator Author

Yes, perfect. Thank you!

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants