Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme 0.41 release #11861

Merged
merged 10 commits into from
Jun 28, 2021
Merged

readme 0.41 release #11861

merged 10 commits into from
Jun 28, 2021

Conversation

dedavis6797
Copy link
Contributor

Summary of the Pull Request

What is this about: Readme for 0.41

What is include in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: #xxx
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@dedavis6797 dedavis6797 requested a review from crutkas June 24, 2021 16:31
htcfreek
htcfreek suggested changes Jun 24, 2021
View reviewed changes
htcfreek
htcfreek reviewed Jun 24, 2021
View reviewed changes
@crutkas crutkas changed the title Update README.md readme 0.41 release Jun 24, 2021
@microsoft microsoft deleted a comment from github-actions bot Jun 24, 2021
@microsoft microsoft deleted a comment from github-actions bot Jun 24, 2021
@microsoft microsoft deleted a comment from github-actions bot Jun 24, 2021
@microsoft microsoft deleted a comment from github-actions bot Jun 24, 2021
@microsoft microsoft deleted a comment from github-actions bot Jun 24, 2021
@microsoft microsoft deleted a comment from github-actions bot Jun 24, 2021
@crutkas
Copy link
Member

crutkas commented Jun 24, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

htcfreek
htcfreek reviewed Jun 26, 2021
View reviewed changes
@htcfreek
Copy link
Collaborator

htcfreek commented Jun 26, 2021 •
edited
Loading

@dedavis6797 , @crutkas
For imageResizer the fix of #11116 is missing

Aaron-Junker
Aaron-Junker requested changes Jun 26, 2021
View reviewed changes
Copy link
Collaborator

@Aaron-Junker Aaron-Junker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also love to see a list of the developers. Not just the triagers.

@crutkas
Copy link
Member

crutkas commented Jun 26, 2021

We only call our community contributors, triage or anyone that does a PR. Every person, in theory, should have been added.

@Aaron-Junker
Copy link
Collaborator

We only call our community contributors, triage or anyone that does a PR. Every person, in theory, should have been added.

@crutkas What's with people like @SeraphimaZ, @yuyoyuppe or @mykhailopylyp

@crutkas
Copy link
Member

crutkas commented Jun 26, 2021

They are PT Core members, so just like me, we don't directly call us out. This is online with community.md file.

@Aaron-Junker
Copy link
Collaborator

They are PT Core members, so just like me, we don't directly call us out. This is online with community.md file.

Oh you're right!

crutkas
crutkas reviewed Jun 28, 2021
View reviewed changes
crutkas
crutkas approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@crutkas crutkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest tweaking that last bit IMO

@dedavis6797 dedavis6797 merged commit e5cb077 into master Jun 28, 2021
@dedavis6797 dedavis6797 deleted the dedavis/readme_0.41 branch June 28, 2021 17:37
@ThiefZero
Copy link
Contributor

ThiefZero commented Jun 29, 2021 •
edited
Loading

Hi, in regards to the Unit Converter entry
I'm not entirely clear on what the requirements for being credited is (except that core members are currently being excluded).

As far as I know, @jsoref worked on the spell-checking github feature. If he's being credited for reviewing that's ok 😄👍. Just asking to make sure he's not missing out on being credited for his spell-check feature.
Either way, I think @htcfreek should definitely be credited here in addition if that's possible since he tested and reviewed the UX side of the feature a lot and helped shape it being in the user friendly way it currently is.

@dedavis6797

royvou pushed a commit to royvou/PowerToys that referenced this pull request Jul 7, 2021
@dedavis6797 @crutkas @royvou
readme 0.41 release (microsoft#11861)
1cf4bfc 
* Update README.md

* Update README.md

* Update README.md

* Create usernames.txt

* Rename usernames.txt to names.txt

* Delete names.txt

* Update expect.txt

* Update README.md

* Update README.md

* Update README.md

Co-authored-by: Clint Rutkas <clint@rutkas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niels9001 niels9001 niels9001 left review comments

@htcfreek htcfreek htcfreek requested changes

@crutkas crutkas crutkas approved these changes

@Aaron-Junker Aaron-Junker Aaron-Junker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dedavis6797 @crutkas @htcfreek @Aaron-Junker @ThiefZero @niels9001