Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/aaron junker/localisation GitHub template #10443

Merged
merged 24 commits into from
Apr 5, 2021

Conversation

Aaron-Junker
Copy link
Collaborator

Summary of the Pull Request

What is this about:

  • Adds the new version of the GitHub issue template for the localisation template
  • Emoji in title changed

image

What is include in the PR:
The new yml template

How does someone test / validate:

Look in a supported browser at https://github.com/microsoft/PowerToys/blob/dev/aaron-junker/localisationGitHubTemplate/.github/ISSUE_TEMPLATE/translation_issue.yml

Quality Checklist

  • Linked issue: Add yml template for localisation issues #10403
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

- type: textarea
attributes:
label: ✔️ Expected phrase(s)
description: Where did you found the affected phrase(s)?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Where did you found the affected phrase(s)?
description: What phrase do you expect here?

attributes:
label: ℹ Why is the current translation wrong
description: If it is opinion based issue, why do you feel this is incorrect?
placeholder: term is outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
placeholder: term is outdated
placeholder: Term is outdated

@htcfreek htcfreek added the Area-GitHub workflow Issues regarding the GitHub workflow and automation label Apr 4, 2021
@crutkas
Copy link
Member

crutkas commented Apr 5, 2021

did some tweaks, will merge in once checks happen

@htcfreek
Copy link
Collaborator

htcfreek commented Apr 5, 2021

@crutkas
please update utility list in drop-down to align with bug template.

@crutkas crutkas merged commit 29ed73b into master Apr 5, 2021
@Aaron-Junker Aaron-Junker deleted the dev/aaron-junker/localisationGitHubTemplate branch April 6, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-GitHub workflow Issues regarding the GitHub workflow and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants