-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/aaron junker/localisation GitHub template #10443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay-o-Way
reviewed
Mar 25, 2021
htcfreek
suggested changes
Mar 25, 2021
- type: textarea | ||
attributes: | ||
label: ✔️ Expected phrase(s) | ||
description: Where did you found the affected phrase(s)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
description: Where did you found the affected phrase(s)? | |
description: What phrase do you expect here? |
attributes: | ||
label: ℹ Why is the current translation wrong | ||
description: If it is opinion based issue, why do you feel this is incorrect? | ||
placeholder: term is outdated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
placeholder: term is outdated | |
placeholder: Term is outdated |
crutkas
approved these changes
Apr 5, 2021
did some tweaks, will merge in once checks happen |
@crutkas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
What is include in the PR:
The new yml template
How does someone test / validate:
Look in a supported browser at https://github.com/microsoft/PowerToys/blob/dev/aaron-junker/localisationGitHubTemplate/.github/ISSUE_TEMPLATE/translation_issue.yml
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.