Skip to content

Conversation

@MrasmussenGit
Copy link
Collaborator

Pull Request (PR) description:

This Pull Request (PR) fixes the following issues:

This fixes #

Task list:

  • Change details added to Unreleased section of CHANGELOG.md (Not required for Convert modules)?
  • Added/updated documentation, comment-based help and descriptions where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

@MrasmussenGit MrasmussenGit linked an issue Sep 11, 2025 that may be closed by this pull request
@MrasmussenGit MrasmussenGit requested review from MrAutomater and Copilot and removed request for Copilot September 11, 2025 14:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes invalid characters from XML self-closing tags in IIS Server STIG configuration files. The changes convert self-closing XML tags to proper opening/closing tag pairs by removing trailing slashes and adding explicit closing tags.

  • Converted self-closing <OrganizationalSettings /> tags to proper opening/closing tag structure
  • Fixed XML syntax in two IIS Server STIG configuration files (versions 3.3 and 3.4)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
source/StigData/Processed/IISServer-10.0-3.4.org.default.xml Converted self-closing OrganizationalSettings tag to opening tag with explicit closing tag
source/StigData/Processed/IISServer-10.0-3.3.org.default.xml Converted self-closing OrganizationalSettings tag to opening tag with explicit closing tag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

associated comment.
-->
<OrganizationalSettings fullversion="3.4" />
<OrganizationalSettings fullversion="3.4" >
Copy link

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space before the closing angle bracket. It should be <OrganizationalSettings fullversion="3.4"> without the trailing space.

Suggested change
<OrganizationalSettings fullversion="3.4" >
<OrganizationalSettings fullversion="3.4">

Copilot uses AI. Check for mistakes.
associated comment.
-->
<OrganizationalSettings fullversion="3.3" />
<OrganizationalSettings fullversion="3.3" >
Copy link

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space before the closing angle bracket. It should be <OrganizationalSettings fullversion="3.3"> without the trailing space.

Suggested change
<OrganizationalSettings fullversion="3.3" >
<OrganizationalSettings fullversion="3.3">

Copilot uses AI. Check for mistakes.
MrAutomater added a commit that referenced this pull request Dec 3, 2025
@MrAutomater
Copy link
Collaborator

Incorporated changes into --> Update PowerStig to parse/apply Microsoft IIS 10.0 Server STIG - Ver 3, Rel 5#1508 #1517

@MrAutomater MrAutomater closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IISServer-10.0-3.3.org.default.xml has invalid XML

3 participants