Skip to content

Added TLS 1.3 support and fixed strict-mode variable errors in tests #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Added TLS 1.3 support and fixed strict-mode variable errors in tests #444

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f3be482
Added TLS 1.3 support for PS Core
variableresistor Jan 8, 2025
a53d6c1
Fixed PowerShell version comparison
variableresistor Jan 8, 2025
6f1b15c
Changed double quotes to single-quotes
variableresistor Jan 8, 2025
e8356b1
Added proper spacing
variableresistor Jan 8, 2025
f42326d
Implemented TLS 1.3 change. Fixed tests.
variableresistor Jan 22, 2025
3f71e21
Made repo variable retrieval call consistent
variableresistor Jan 22, 2025
32e93d9
Fixed variable missing error in test
variableresistor Jan 22, 2025
0ef46ba
Fixed more strict mode variable errors
variableresistor Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions GitHubCore.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,10 @@ function Invoke-GHRestMethod
# Disable Progress Bar in function scope during Invoke-WebRequest
$ProgressPreference = 'SilentlyContinue'

[Net.ServicePointManager]::SecurityProtocol=[Net.SecurityProtocolType]::Tls12
if ($PSVersionTable.PSVersion -lt 7.0.0)
{
[Net.ServicePointManager]::SecurityProtocol=[Net.SecurityProtocolType]::Tls12
}

$result = Invoke-WebRequest @params

Expand Down Expand Up @@ -582,7 +585,10 @@ function Invoke-GHRestMethod
}
finally
{
[Net.ServicePointManager]::SecurityProtocol = $originalSecurityProtocol
if ($PSVersionTable.PSVersion -lt 7.0.0)
{
[Net.ServicePointManager]::SecurityProtocol = $originalSecurityProtocol
}
}
}

Expand Down