Skip to content

Pester v5 #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 49 commits into from
Dec 16, 2022
Merged

Pester v5 #366

merged 49 commits into from
Dec 16, 2022

Conversation

tigerfansga
Copy link
Contributor

@tigerfansga tigerfansga commented Sep 22, 2022

Description

Update pester test for Pester v5 support

Issues Fixed

References

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Formatters were created for any new types being added.
  • New/changed code continues to support the pipeline.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

@ghost
Copy link

ghost commented Sep 22, 2022

CLA assistant check
All CLA requirements met.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky
Copy link
Contributor

@tigerfansga - You'll need to sign the CLA via the bot using the command @microsoft-github-policy-service agree.

Still looking through the test failures to see if there's anything there related to your changes...

@tigerfansga
Copy link
Contributor Author

@tigerfansga - You'll need to sign the CLA via the bot using the command @microsoft-github-policy-service agree.

Still looking through the test failures to see if there's anything there related to your changes...

That is strange on the CLA because I had accepted it. I can get that done later today. I'm not sure I'll be able to review any requested changes till after the New Year.

@ghost ghost removed the needs-author-feedback label Dec 15, 2022
Error message has changed.  Modifying test to simply capture that a failure occurred (without validating the string itself)
@tigerfansga
Copy link
Contributor Author

@microsoft-github-policy-service agree

Removes the specific error message check from the `Throw` validation of some tests since the wording of the exception message keeps changing.
@HowardWolosky
Copy link
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Update the PowerShell extension in VS Code to take advantage of the fact that the tests are now Pester 5 compatible.  This allows each individual block to have a Run/Debug link associated with it.
Disabling the tests since they no longer work.
Disabling since classic projects have been deprecated.
Disabling since classic projects are no longer supported.
@HowardWolosky
Copy link
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky
Copy link
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky HowardWolosky merged commit 5e1a4b3 into microsoft:master Dec 16, 2022
@HowardWolosky
Copy link
Contributor

I cleaned up the remaining work in here and got it merged in. Thanks so much to @tigerfansga for taking this work on and moving the project forward. It's HUGE that we can now run individual tests directly within VS Code now that we're on Pester 5.
Thanks so much for the contribution!

@tigerfansga tigerfansga deleted the PesterV5 branch March 7, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get unit tests working against Pester 5.x
2 participants