Hubspot CMS #886
Merged
Hubspot CMS #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamurshe
reviewed
Jun 15, 2021
| "type": "integer", | ||
| "format": "int32", | ||
| "description": "The category id of the template", | ||
| "title": "", |
There was a problem hiding this comment.
Please fix all the titles.
|
[[certify-connector]] |
|
[[certify-connector]] |
1 similar comment
|
[[certify-connector]] |
|
Updated apiProperties |
mamurshe
suggested changes
Jun 28, 2021
There was a problem hiding this comment.
When I try to create a custom connector using these asset with paconn CLI I get an error. Can you please update the apiProperties.json using paconn download command?
independent-publisher-connectors\HubSpot CMS>paconn create -d apiDefinition.swagger.json -p apiProperties.json -e 5827fea3-d788-43a6-9861-3c82de256bce
'properties'
Traceback (most recent call last):
File "c:\python\lib\site-packages\knack\cli.py", line 206, in invoke
cmd_result = self.invocation.execute(args)
File "c:\python\lib\site-packages\knack\invocation.py", line 188, in execute
cmd_result = parsed_args.func(params)
File "c:\python\lib\site-packages\knack\commands.py", line 131, in __call__
return self.handler(*args, **kwargs)
File "c:\python\lib\site-packages\knack\commands.py", line 238, in _command_handler
result = op(client, **command_args) if client else op(**command_args)
File "c:\python\lib\site-packages\paconn\commands\create.py", line 47, in create
connector_id = upsert(
File "c:\python\lib\site-packages\paconn\operations\upsert.py", line 82, in upsert
properties = property_definition[_PROPERTIES]
KeyError: 'properties'
mamurshe
suggested changes
Jun 30, 2021
mamurshe
suggested changes
Jul 2, 2021
There was a problem hiding this comment.
Can you please add connectionParameters section as shown below? It's needed for deployment.
"properties": {
"connectionParameters": {
"api_key": {
"type": "securestring",
"uiDefinition": {
"constraints": {
"clearText": false,
"required": "true",
"tabIndex": 3
},
"schema": {
"description": "Enter your API Key for HubSpot",
"type": "securestring"
},
"displayName": "API Key generated in HubSpot"
}
}
},
"connectionParameterSets": {
mamurshe
suggested changes
Jul 16, 2021
| @@ -0,0 +1,75 @@ | |||
| { | |||
There was a problem hiding this comment.
Please delete the api-key auth.
{
"properties": {
"connectionParameters": {
"token": {
"type": "oauthSetting",
"oAuthSettings": {
"identityProvider": "oauth2",
"clientId": "[Your_Value]",
"scopes": [
"forms files hubdb transactional-email settings.users.write conversations.visitor_identification.tokens.create integration-sync tickets e-commerce files.ui_hidden.read crm.objects.marketing_events.read accounting crm.objects.marketing_events.write crm.schemas.custom.read crm.objects.custom.read crm.objects.feedback_submissions.read sales-email-read crm.objects.custom.write forms-uploaded-files settings.users.read crm.import contacts content reports social automation settings.billing.write actions timeline business-intelligence"
],
"redirectMode": "Global",
"redirectUrl": "https://global.consent.azure-apim.net/redirect",
"properties": {
"IsFirstParty": "False"
},
"customParameters": {
"authorizationUrl": {
"value": "https://app.hubspot.com/oauth/authorize"
},
"tokenUrl": {
"value": "https://api.hubapi.com/oauth/v1/token"
},
"refreshUrl": {
"value": "https://api.hubapi.com/oauth/v1/token"
}
}
}
}
},
"iconBrandColor": "#da3b01",
"capabilities": [],
"publisher": "Hitachi Solutions",
"stackOwner": "HubSpot"
}
}
| "definitions": {}, | ||
| "parameters": {}, | ||
| "responses": {}, | ||
| "securityDefinitions": { |
There was a problem hiding this comment.
Please remove securityDefinitons since API Properties file already has the definition.
| } | ||
| } | ||
| }, | ||
| "security": [ |
There was a problem hiding this comment.
Please remove security since API Properties file already has the definition.
joshuaapple
pushed a commit
to docjuris/PowerPlatformConnectors
that referenced
this pull request
Oct 6, 2021
* certify-connector HubSpot CRM, CMS, and Marketing connectors * certify-connector Xero Accounting and Payroll connectors * Revert "certify-connector" This reverts commit 5fb06db. * Revert "certify-connector" This reverts commit 160b208. * certify-connector * certify-connector * certify-connector * Update apiDefinition.swagger.json Fixed description * Update apiDefinition.swagger.json Cut to below 500 * Update apiDefinition.swagger.json Cut to below 500. * Delete icon.png * Delete settings.json * Delete independent-publisher-connectors/HubSpot CRM directory * Delete independent-publisher-connectors/HubSpot Marketing directory * Delete independent-publisher-connectors/Xero Accounting directory * Delete independent-publisher-connectors/Xero Payroll - UK directory * Delete independent-publisher-connectors/Xero Projects directory * Fix remaining descriptions, scope should be string * Fix clientId * apiProperties fix * Update apiProperties.json * Update README.md * Update README.md * Update apiProperties.json * Update apiProperties.json * Change connectionParameters to parameters * Update required scopes * Change to "redirectUrl": "https://global.consent.azure-apim.net/redirect" * Fixed scopes * Removed unused scopes * Fix hapikey * Removed API key connection * Removed security Co-authored-by: Mahbub Murshed <mamurshe@microsoft.com> Co-authored-by: Mahbub Murshed <48570820+mamurshe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting a connector, please check the following conditions for your PR.
apiDefinition.swagger.json, by runningpaconn validatecommand.apiProperties.jsonhas a valid brand color and doesn't use an invalid brand color,#007ee5or#ffffff.