version 2 #837
Merged
version 2 #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes include: Removing "Get Historical Data" action as this was exposing a Web API end-point marked as obsolete. Correcting a number of the defined response schemas that had content nested under a "datasource" element. Updating action descriptions and markdown readme. Adding required meta data to swagger API definition.
|
|
|
@gsmcmurtrie Please sign the CLA |
sriyen-msft
requested changes
May 21, 2021
certified-connectors/Industrial App Store/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
| @@ -5,7 +5,7 @@ | |||
| "type": "oauthSetting", | |||
| "oAuthSettings": { | |||
| "identityProvider": "oauth2", | |||
| "clientId": "<<Please add your clientID here>>", | |||
| "clientId": "18e880e61fe84e9485fda4eb41462554", | |||
There was a problem hiding this comment.
@gsmcmurtrie You can replace the clientId value with [[Dummy]]
| @@ -28,7 +28,9 @@ | |||
| } | |||
| } | |||
| }, | |||
| "iconBrandColor": "#CCCCCC", | |||
| "capabilities": [] | |||
| "iconBrandColor": "#ffffff", | |||
There was a problem hiding this comment.
@gsmcmurtrie Please note that white background color for icon is not allowed.
Documentation - Icon
|
@gsmcmurtrie You have submitted the intro.md instead of readme.md in open repo. There is a difference between intro.md and readme.md files, the intro.md file is required for certification and its content would be published and displayed in your connector's documentation page. Readme.md file is only required for open sourcing your connector which can be helpful to the open source users who may want to contribute in your connector. Here is an example |
Response descriptions improved. ReadMe edited to something more succinct. Icon background colour changed to an allowed value.
sriyen-msft
approved these changes
May 28, 2021
rostislavrusev
added a commit
to rostislavrusev/PowerPlatformConnectors
that referenced
this pull request
May 31, 2021
* Alemba ITSM Connector * Fixed readme and intro files * Fixed formatting of images * Formatting and images fix * Update Intro.md * version 2 (microsoft#837) * version 2 Changes include: Removing "Get Historical Data" action as this was exposing a Web API end-point marked as obsolete. Correcting a number of the defined response schemas that had content nested under a "datasource" element. Updating action descriptions and markdown readme. Adding required meta data to swagger API definition. * Improvements requested by certification team Response descriptions improved. ReadMe edited to something more succinct. Icon background colour changed to an allowed value. * Origin/secplugs/dev (microsoft#824) * Added Secplug Scan Added Secplug Scan * Add files via upload * Updated brand color Updated Brand color * Add files via upload * Update readme.md * Update apiDefinition.swagger.json * Update readme.md * Delete settings.json * Update apiProperties.json * Update apiDefinition.swagger.json * taken care of comments * updated background color Co-authored-by: moolchand <58115278+moolchand@users.noreply.github.com> * Delete Intro.md Removed intro.md Co-authored-by: Rostislav Rusev <rostislav.rusev@concordeu.com> Co-authored-by: djball3678 <44480707+djball3678@users.noreply.github.com> Co-authored-by: gsmcmurtrie <gregor.mcmurtrie@intelligentplant.com> Co-authored-by: Ajaatsecplugs <61938145+Ajaatsecplugs@users.noreply.github.com> Co-authored-by: moolchand <58115278+moolchand@users.noreply.github.com>
sriyen-msft
pushed a commit
that referenced
this pull request
Jun 2, 2021
* Alemba/connector (#2) * Alemba ITSM Connector * Fixed readme and intro files * Fixed formatting of images * Formatting and images fix * Update Intro.md Co-authored-by: Rostislav Rusev <rostislav.rusev@concordeu.com> Co-authored-by: djball3678 <44480707+djball3678@users.noreply.github.com> * Alemba/connector (#3) * Alemba ITSM Connector * Fixed readme and intro files * Fixed formatting of images * Formatting and images fix * Update Intro.md * version 2 (#837) * version 2 Changes include: Removing "Get Historical Data" action as this was exposing a Web API end-point marked as obsolete. Correcting a number of the defined response schemas that had content nested under a "datasource" element. Updating action descriptions and markdown readme. Adding required meta data to swagger API definition. * Improvements requested by certification team Response descriptions improved. ReadMe edited to something more succinct. Icon background colour changed to an allowed value. * Origin/secplugs/dev (#824) * Added Secplug Scan Added Secplug Scan * Add files via upload * Updated brand color Updated Brand color * Add files via upload * Update readme.md * Update apiDefinition.swagger.json * Update readme.md * Delete settings.json * Update apiProperties.json * Update apiDefinition.swagger.json * taken care of comments * updated background color Co-authored-by: moolchand <58115278+moolchand@users.noreply.github.com> * Delete Intro.md Removed intro.md Co-authored-by: Rostislav Rusev <rostislav.rusev@concordeu.com> Co-authored-by: djball3678 <44480707+djball3678@users.noreply.github.com> Co-authored-by: gsmcmurtrie <gregor.mcmurtrie@intelligentplant.com> Co-authored-by: Ajaatsecplugs <61938145+Ajaatsecplugs@users.noreply.github.com> Co-authored-by: moolchand <58115278+moolchand@users.noreply.github.com> * Delete Intro.md Co-authored-by: Rostislav Rusev <rostislav.rusev@concordeu.com> Co-authored-by: djball3678 <44480707+djball3678@users.noreply.github.com> Co-authored-by: gsmcmurtrie <gregor.mcmurtrie@intelligentplant.com> Co-authored-by: Ajaatsecplugs <61938145+Ajaatsecplugs@users.noreply.github.com> Co-authored-by: moolchand <58115278+moolchand@users.noreply.github.com>
joshuaapple
pushed a commit
to docjuris/PowerPlatformConnectors
that referenced
this pull request
Oct 6, 2021
* version 2 Changes include: Removing "Get Historical Data" action as this was exposing a Web API end-point marked as obsolete. Correcting a number of the defined response schemas that had content nested under a "datasource" element. Updating action descriptions and markdown readme. Adding required meta data to swagger API definition. * Improvements requested by certification team Response descriptions improved. ReadMe edited to something more succinct. Icon background colour changed to an allowed value.
joshuaapple
pushed a commit
to docjuris/PowerPlatformConnectors
that referenced
this pull request
Oct 6, 2021
* Alemba/connector (microsoft#2) * Alemba ITSM Connector * Fixed readme and intro files * Fixed formatting of images * Formatting and images fix * Update Intro.md Co-authored-by: Rostislav Rusev <rostislav.rusev@concordeu.com> Co-authored-by: djball3678 <44480707+djball3678@users.noreply.github.com> * Alemba/connector (microsoft#3) * Alemba ITSM Connector * Fixed readme and intro files * Fixed formatting of images * Formatting and images fix * Update Intro.md * version 2 (microsoft#837) * version 2 Changes include: Removing "Get Historical Data" action as this was exposing a Web API end-point marked as obsolete. Correcting a number of the defined response schemas that had content nested under a "datasource" element. Updating action descriptions and markdown readme. Adding required meta data to swagger API definition. * Improvements requested by certification team Response descriptions improved. ReadMe edited to something more succinct. Icon background colour changed to an allowed value. * Origin/secplugs/dev (microsoft#824) * Added Secplug Scan Added Secplug Scan * Add files via upload * Updated brand color Updated Brand color * Add files via upload * Update readme.md * Update apiDefinition.swagger.json * Update readme.md * Delete settings.json * Update apiProperties.json * Update apiDefinition.swagger.json * taken care of comments * updated background color Co-authored-by: moolchand <58115278+moolchand@users.noreply.github.com> * Delete Intro.md Removed intro.md Co-authored-by: Rostislav Rusev <rostislav.rusev@concordeu.com> Co-authored-by: djball3678 <44480707+djball3678@users.noreply.github.com> Co-authored-by: gsmcmurtrie <gregor.mcmurtrie@intelligentplant.com> Co-authored-by: Ajaatsecplugs <61938145+Ajaatsecplugs@users.noreply.github.com> Co-authored-by: moolchand <58115278+moolchand@users.noreply.github.com> * Delete Intro.md Co-authored-by: Rostislav Rusev <rostislav.rusev@concordeu.com> Co-authored-by: djball3678 <44480707+djball3678@users.noreply.github.com> Co-authored-by: gsmcmurtrie <gregor.mcmurtrie@intelligentplant.com> Co-authored-by: Ajaatsecplugs <61938145+Ajaatsecplugs@users.noreply.github.com> Co-authored-by: moolchand <58115278+moolchand@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
Removing "Get Historical Data" action as this was exposing a Web API end-point marked as obsolete.
Correcting a number of the defined response schemas that had content nested under a "datasource" element.
Updating action descriptions and markdown readme.
Adding required meta data to swagger API definition.
Please check the following conditions for your PR.
apiDefinition.swagger.jsonis validated usingpaconn validatecommand.apiProperties.jsonhas a valid brand color. Invalid brand colors are#007ee5and#ffffff.