Skip to content

Conversation

@mikefactorial
Copy link
Contributor

This PR contains the source for a previously certified connector that was not open sourced at the time. There are several updates to the actions in this source as well including new actions related to finance as well as the required readme.md and metadata in the swagger json.

Please check the following conditions for your PR.

  • [ x] apiDefinition.swagger.json is validated using paconn validate command.
  • [ x] apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

calvinleong and others added 13 commits November 5, 2020 11:58
)

* Update apiDefinition.swagger.json

* Add files via upload

* update readme

* Update Get User Info Action and apiProperties file
* Create IN-D KYC India

* Delete IN-D KYC India

* Create apiDefinition.swagger.json

* Add files via upload

* Create README.MD

* Update README.MD

* Delete README.MD

* Delete apiDefinition.swagger.json

* Delete apiProperties.json

* Create IN-D Insurance

* Delete IN-D Insurance

* Create IN-D Insurance

* Delete IN-D Insurance

* Create Readme.md

* Add files via upload

* Add files via upload

* Delete Readme.md

* Delete apiDefinition.swagger.json

* Delete apiProperties.json

* Create Readme.md

* Add files via upload

* Add files via upload
@mikefactorial mikefactorial requested a review from a team as a code owner March 14, 2021 18:46
Copy link
Contributor

@sriyen-msft sriyen-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikefactorial The swagger is not up-to-date with the swagger you have provided in the certification portal. Please let us know if this is an update to your connector and you want to update your connector.

@mikefactorial
Copy link
Contributor Author

mikefactorial commented Mar 16, 2021

Hi @sriyen-msft. Thanks for the prompt response!

This is an update, but also the first time this connector's source has been submitted to the repo since it was previously certified before the requirement for open sourcing.

Following the instructions in the docs my assumption was we needed to submit the PR with the updates prior to submitting the updates to the connector via the ISV Studio. Let me know if we did something out of order. Thanks again!

From the Docs: “Updates to certified connectors must first be made through a pull request to the dev branch for review by the connector owner. Once a pull request has been merged to the dev branch, the connector owner can submit the connector for certification through the Connector certification tab in ISV Studio. Once certified, the Microsoft Certification team will handle merging the updates from dev to master.” - https://github.com/Microsoft/PowerPlatformConnectors#contributing

@mikefactorial
Copy link
Contributor Author

@sriyen-msft I've made the requested changes. I wasn't sure if I needed to rerequest your review after making the changes, but I did so if that was a mistake in protocol let me know so I don't do it again next time :)

@sriyen-msft sriyen-msft merged commit f5b5796 into microsoft:dev Mar 23, 2021
sriyen-msft pushed a commit that referenced this pull request Jun 17, 2021
* Updating with latest API Definition JSON

* Updating with latest API Definition and Properties

* Updates / Fixes for paconn validate issues

* Additional fixes for paconn validation

* Updated formatting with new export

* Fix for multiple x-ms-connector-metadata definitions

* Updating readme with current list of operations

* removing extra files and updates to readme.md

* Read Me Updates for Prerequisite.

* Updating icon brand color

* Committing changes based on feedback from @sriyen-msft after initial PR #722

* Updated support website

* Updated Response type

* Removed extraneous folder

Co-authored-by: Michael Ochs <mike@mikefactorial.com>
joshuaapple pushed a commit to docjuris/PowerPlatformConnectors that referenced this pull request Oct 6, 2021
* Updating with latest API Definition JSON

* Updating with latest API Definition and Properties

* Updates / Fixes for paconn validate issues

* Additional fixes for paconn validation

* Updated formatting with new export

* Fix for multiple x-ms-connector-metadata definitions

* Updating readme with current list of operations

* removing extra files and updates to readme.md

* Read Me Updates for Prerequisite.

* Updating icon brand color

* Committing changes based on feedback from @sriyen-msft after initial PR microsoft#722

* Updated support website

* Updated Response type

* Removed extraneous folder

Co-authored-by: Michael Ochs <mike@mikefactorial.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants