Add SwiftKanban connector #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dougelliott
suggested changes
Feb 12, 2021
There was a problem hiding this comment.
Could this please be put into the certified-connectors directory, rather than the custom-connectors directory? Additionally, please include a readme.md. You can take a look at other connectors located in the certified-connectors directory for some examples.
Thanks!
sriyen-msft
requested changes
Feb 17, 2021
| "/restapi/comment-operations/boards/{boardId}/cards/{cardType}:{cardId}/comments": { | ||
| "post": { | ||
| "responses": { | ||
| "default": { |
There was a problem hiding this comment.
@mx012 We would recommend you to replace ALL the "default" responses with expected status codes, otherwise users may see errors about incorrect schema instead of real error responses from your service in OpenAPI mode.
There was a problem hiding this comment.
I have added the status codes now. Please check. Thanks!
mx012
changed the title
dougelliott
approved these changes
Feb 18, 2021
sriyen-msft
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the following conditions for your PR.
apiDefinition.swagger.jsonis validated usingpaconn validatecommand.apiProperties.jsonhas a valid brand color. Invalid brand colors are#007ee5and#ffffff.