Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e-sign custom connector #662

Merged
merged 2 commits into from
Jan 27, 2021
Merged

e-sign custom connector #662

merged 2 commits into from
Jan 27, 2021

Conversation

eSignHQ
Copy link
Contributor

@eSignHQ eSignHQ commented Jan 18, 2021


Please check the following conditions for your PR.

  • apiDefinition.swagger.json is validated using paconn validate command.
  • apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

@eSignHQ eSignHQ requested a review from a team as a code owner January 18, 2021 11:25
@ghost
Copy link

ghost commented Jan 18, 2021

CLA assistant check
All CLA requirements met.

@dougelliott
Copy link
Contributor

@eSignHQ Could the files please be placed within the certified-connectors directory, rather than the custom-connectors directory? Thanks!

@eSignHQ
Copy link
Contributor Author

eSignHQ commented Jan 20, 2021

@dougelliott done now.

@sriyen-msft
Copy link
Contributor

@eSignHQ Please remove icon from the PR

@eSignHQ
Copy link
Contributor Author

eSignHQ commented Jan 22, 2021

There is no logo in the PR?

@eSignHQ
Copy link
Contributor Author

eSignHQ commented Jan 26, 2021

Is this OK?

@dougelliott
Copy link
Contributor

@eSignHQ This looks good, I will go ahead and approve :)

@dougelliott dougelliott merged commit a07488c into microsoft:dev Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants