-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding files #650
Adding files #650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the comment, please have these files go into the certified-connectors
directory, not the custom-connectors
directory. Thanks!
"info": { | ||
"title": "Elead Product Reference Data", | ||
"version": "1.0", | ||
"description": "This API provides data to be used in conjunction with other eLeads APIs as needed.API searches, retrieves and provides the following details - Opportunity sources and sub sources for a specified company and up types, opportunity statuses for a specified company, sales steps for a specified company, employee positions for a specified company, employees by company and position, sender email addresses for a specified company, available vehicle class, year, make, model, trim.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a missing space after other eLeads APIs as needed
and the following sentence of API searches, retrieves and provides the following
in the description
"connectionParameters": {}, | ||
"iconBrandColor": "#1F1A3C", | ||
"capabilities": [], | ||
"publisher": "Bhargava, Aman Avinash" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the stackOwner
property, and remove any PII. The publisher and stackowner fields should point to the company, not an individual, for certified connnectors.
@dougelliott & @sriyen-msft made required code review changes |
Please check the following conditions for your PR.
apiDefinition.swagger.json
is validated usingpaconn validate
command.apiProperties.json
has a valid brand color. Invalid brand colors are#007ee5
and#ffffff
.