Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding files #650

Merged
merged 4 commits into from
Jan 15, 2021
Merged

Adding files #650

merged 4 commits into from
Jan 15, 2021

Conversation

amancdk
Copy link
Contributor

@amancdk amancdk commented Jan 11, 2021


Please check the following conditions for your PR.

  • apiDefinition.swagger.json is validated using paconn validate command.
  • apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

@amancdk amancdk requested a review from a team as a code owner January 11, 2021 20:03
@amancdk amancdk mentioned this pull request Jan 11, 2021
2 tasks
Copy link
Contributor

@dougelliott dougelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comment, please have these files go into the certified-connectors directory, not the custom-connectors directory. Thanks!

"info": {
"title": "Elead Product Reference Data",
"version": "1.0",
"description": "This API provides data to be used in conjunction with other eLeads APIs as needed.API searches, retrieves and provides the following details - Opportunity sources and sub sources for a specified company and up types, opportunity statuses for a specified company, sales steps for a specified company, employee positions for a specified company, employees by company and position, sender email addresses for a specified company, available vehicle class, year, make, model, trim.",
Copy link
Contributor

@dougelliott dougelliott Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing space after other eLeads APIs as needed and the following sentence of API searches, retrieves and provides the following in the description

"connectionParameters": {},
"iconBrandColor": "#1F1A3C",
"capabilities": [],
"publisher": "Bhargava, Aman Avinash"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the stackOwner property, and remove any PII. The publisher and stackowner fields should point to the company, not an individual, for certified connnectors.

sriyen-msft
sriyen-msft previously approved these changes Jan 14, 2021
@amancdk
Copy link
Contributor Author

amancdk commented Jan 15, 2021

@dougelliott & @sriyen-msft made required code review changes

@dougelliott dougelliott merged commit c9efa52 into microsoft:dev Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants