Skip to content

Conversation

@YannickRe
Copy link
Contributor

Add the ability to use a configurable host url so customers can connect to their own Connective eSignatures environment


Please check the following conditions for your PR.

  • apiDefinition.swagger.json is validated using paconn validate command.
  • apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

@YannickRe YannickRe requested a review from a team as a code owner December 16, 2020 13:46
@YannickRe
Copy link
Contributor Author

Not sure why the swagger validation failed, because I made no changes to that file.
Also, I got this in mail:
image

Anything I need to do?

@dougelliott
Copy link
Contributor

@YannickRe I'll go ahead and re-run the check. If it fails again, we'll dig deeper into what is going wrong. You can disregard any emails about it.

pmarzouk-cnve
pmarzouk-cnve previously approved these changes Dec 17, 2020
Copy link
Contributor

@pmarzouk-cnve pmarzouk-cnve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for Connective

@YannickRe
Copy link
Contributor Author

@dougelliott It seems like this still failed, but the error message is kind of non-descriptive... Anything I can do on my end?

@dougelliott
Copy link
Contributor

@YannickRe Sorry about that, we'll take a look on our side and see what's happening.

@mamurshe
Copy link
Contributor

@YannickRe Sorry about the trouble with the validation error. I was able to reproduce on my end and fixed by specifying UTF-8 encoding setting in the validation pipeline. I pushed this fix to the dev branch. Can you please update the dev branch from your git clone and merge the dev branch to your branch?
From your local copy of the source do the following:
git checkout dev
git pull
git checkout connective-urlTemplate
git merge dev
git push

…ct to their own Connective eSignatures environment
@YannickRe
Copy link
Contributor Author

@mamurshe This seems to have done the trick, thank you for the investigative action and happy it wasn't me 😉
@pmarzouk-cnve Sorry about this, but it seems like you need to re-approve this change...
@dougelliott Thanks for taking action! We really like to get this change out in to the world 🙂

@sriyen-msft sriyen-msft merged commit d6208ed into microsoft:dev Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants