Entersoft connector for Microsoft Power Apps for the Entersoft Business Suite family products

[entersoftsa]

---

Please check the following conditions for your PR.

• apiDefinition.swagger.json is validated using paconn validate command.
• apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

[ghost]

All CLA requirements met.

[dougelliott]

Could the description of the connector be expanded a little bit? Even just a sentence or two about very high-level functionality the connector offers would be helpful in users understanding more about the connector.

[entersoftsa]

Hi Doug, By all means. I am doing it right away, and I will committed to the branch Σταύρος Μένεγος Stavros Menegos Technical Director E sme@entersoft.gr [cid:image001.png@01D6D45A.DD4378A0] [cid:image002.png@01D6D45A.DD4378A0] [cid:image003.png@01D6D45A.DD4378A0]<www.entersoft.gr> www.entersoft.gr<http://www.entersoft.gr> [cid:image004.png@01D6D45A.DD4378A0] +30.211.101.5000 [cid:image005.png@01D6D45A.DD4378A0]<http://www.facebook.com/ENTERSOFT> [cid:image006.png@01D6D45A.DD4378A0] <http://twitter.com/ENTERSOFT_SA> [cid:image007.png@01D6D45A.DD4378A0] <http://www.linkedin.com/company/entersoft> [cid:image008.png@01D6D45A.DD4378A0] <http://www.youtube.com/user/EntersoftSoftware> [cid:image009.png@01D6D45A.DD4378A0]<https://www.entersoft.gr/2018/03/20/tec-ebs/> Σημείωση: Αυτό το ηλεκτρονικό μήνυμα μαζί με τα τυχόν επισυναπτόμενα του είναι εμπιστευτικό και προορίζεται μόνο για χρήση από τα άτομα στα οποία απευθύνεται. Εάν δεν είστε ο προοριζόμενος παραλήπτης ή αρμόδιος για την παράδοση του μηνύματος στον προοριζόμενο παραλήπτη, παρακαλώ επιστρέψτε το στον αποστολέα και διαγράψτε αμέσως όλα τα αντίγραφα. Απαγορεύεται η αντιγραφή ή αναπαραγωγή του παρόντος μηνύματος από τον μη προοριζόμενο παραλήπτη. Το ηλεκτρονικό μήνυμα και οποιαδήποτε αρχεία είναι συνημμένα σ’ αυτό έχουν ελεγχθεί για την ύπαρξη ιών, ωστόσο είναι ευθύνη του παραλήπτη να ελέγξει τη μη ύπαρξη ιών και η Entersoft δεν αποδέχεται καμία ευθύνη για οποιαδήποτε απώλεια δεδομένων ή ζημία πιθανώς προκύψει από την χρήση τους. | Disclaimer: This e-mail including any attachments is confidential and is intended solely for the use of the named individual or entity to which it is addressed. If you are not the intended recipient, or the person responsible for delivering the message to the intended recipient, please return it to sender and delete it immediately. Unauthorised distribution or copy of this email by the non-indented recipient is strictly prohibited. This e-mail and any attachments are believed to be free of any virus or other defect, however, it is the responsibility of the recipient to ensure that it is virus free and Entersoft accepts no liability for any loss of data or damage arising in any way from its use. From: Doug Elliott <notifications@github.com> Sent: Thursday, December 17, 2020 5:41 AM To: microsoft/PowerPlatformConnectors <PowerPlatformConnectors@noreply.github.com> Cc: Stavros Menegos <sme@entersoft.gr>; Author <author@noreply.github.com> Subject: Re: [microsoft/PowerPlatformConnectors] Entersoft connector for Microsoft Power Apps for the Entersoft Business Suite family products (#611) @dougelliott requested changes on this pull request. Could the description of the connector be expanded a little bit? Even just a sentence or two about very high-level functionality the connector offers would be helpful in users understanding more about the connector. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#611 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB4X6AT2DGMTU6MO7F5V3QDSVF4VZANCNFSM4U3BRLZQ>.

[entersoftsa]

Hi, I committed version 0.2 of Entersoft Connector. Now the README.md contains a more detailed description. Regards, Σταύρος Μένεγος Stavros Menegos Technical Director E sme@entersoft.gr [cid:image001.png@01D6D4C5.D253EE50] [cid:image002.png@01D6D4C5.D253EE50] [cid:image003.png@01D6D4C5.D253EE50]<www.entersoft.gr> www.entersoft.gr<http://www.entersoft.gr> [cid:image004.png@01D6D4C5.D253EE50] +30.211.101.5000 [cid:image005.png@01D6D4C5.D253EE50]<http://www.facebook.com/ENTERSOFT> [cid:image006.png@01D6D4C5.D253EE50] <http://twitter.com/ENTERSOFT_SA> [cid:image007.png@01D6D4C5.D253EE50] <http://www.linkedin.com/company/entersoft> [cid:image008.png@01D6D4C5.D253EE50] <http://www.youtube.com/user/EntersoftSoftware> [cid:image009.png@01D6D4C5.D253EE50]<https://www.entersoft.gr/2018/03/20/tec-ebs/> Σημείωση: Αυτό το ηλεκτρονικό μήνυμα μαζί με τα τυχόν επισυναπτόμενα του είναι εμπιστευτικό και προορίζεται μόνο για χρήση από τα άτομα στα οποία απευθύνεται. Εάν δεν είστε ο προοριζόμενος παραλήπτης ή αρμόδιος για την παράδοση του μηνύματος στον προοριζόμενο παραλήπτη, παρακαλώ επιστρέψτε το στον αποστολέα και διαγράψτε αμέσως όλα τα αντίγραφα. Απαγορεύεται η αντιγραφή ή αναπαραγωγή του παρόντος μηνύματος από τον μη προοριζόμενο παραλήπτη. Το ηλεκτρονικό μήνυμα και οποιαδήποτε αρχεία είναι συνημμένα σ’ αυτό έχουν ελεγχθεί για την ύπαρξη ιών, ωστόσο είναι ευθύνη του παραλήπτη να ελέγξει τη μη ύπαρξη ιών και η Entersoft δεν αποδέχεται καμία ευθύνη για οποιαδήποτε απώλεια δεδομένων ή ζημία πιθανώς προκύψει από την χρήση τους. | Disclaimer: This e-mail including any attachments is confidential and is intended solely for the use of the named individual or entity to which it is addressed. If you are not the intended recipient, or the person responsible for delivering the message to the intended recipient, please return it to sender and delete it immediately. Unauthorised distribution or copy of this email by the non-indented recipient is strictly prohibited. This e-mail and any attachments are believed to be free of any virus or other defect, however, it is the responsibility of the recipient to ensure that it is virus free and Entersoft accepts no liability for any loss of data or damage arising in any way from its use. From: Doug Elliott <notifications@github.com> Sent: Thursday, December 17, 2020 5:41 AM To: microsoft/PowerPlatformConnectors <PowerPlatformConnectors@noreply.github.com> Cc: Stavros Menegos <sme@entersoft.gr>; Author <author@noreply.github.com> Subject: Re: [microsoft/PowerPlatformConnectors] Entersoft connector for Microsoft Power Apps for the Entersoft Business Suite family products (#611) @dougelliott requested changes on this pull request. Could the description of the connector be expanded a little bit? Even just a sentence or two about very high-level functionality the connector offers would be helpful in users understanding more about the connector. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#611 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB4X6AT2DGMTU6MO7F5V3QDSVF4VZANCNFSM4U3BRLZQ>.

[dougelliott]

@entersoftsa First, thanks so much for the changes to the readme! Those are fantastic improvements and will definitely help users of the connector. In relation to my initial feedback, I was actually referring to the description field located in the apiDefinition.swagger.json file, which is the "main" description for the connector. This is one of the first things a customer will likely read when looking at the connector, so it's good for it to not only contain high-level information about the service, but also high-level information about the functionality of the connector. The maximum length of that description field can be 500 characters, so you're more than welcome to use up to that amount to expand on the value the connector offers customers.

[sriyen-msft]

@entersoftsa The description of connector can be improved, Can you please provide a detailed description which every one can understand about your connector.
Refer - Documentation

[sriyen-msft]

@entersoftsa Summary values of the operations looks like opertaionIds, Can you please provide a valid sentence for every summary value, wherever it applies in the swagger .
Ex.: Line number 25 - "summary": "GetInfo"
Refer - Documentation

[sriyen-msft]

@entersoftsa Please replace all the unicodes used in the artifacts with English language characters.

[sriyen-msft]

@entersoftsa Please note that it is not allowed to have non-English characters in any of the connector artifacts. You can raise a separate request for localization of your connector once it is certified.

Ex: Line number 7399 - EInvoice_\u0391dditionalInterchangeableExpense1_Description":

[sriyen-msft]

@entersoftsa There is a limitation to each connector for having 128 operations and 512 definitions. Please let us know if your connector is exceeding the limitation.

[entersoftsa]

All of the issues raised in the previous comments have been resolved with the commit 0.6

[entersoftsa]

Fixed

[sriyen-msft]

@entersoftsa There are few operations have description values which looks like operationids. Please replace them with valid sentences as these would be visible to public.

Line number : 459

 "summary": "Add or Update an entity's Related Documents",
"description": "AddOrUpdateAttachedDocument",
"operationId": "ES00Documents_AddOrUpdateAttachedDocument",

[sriyen-msft]

@entersoftsa Few operation summary values are still looking like operation Ids instead of a valid sentence.

Ex.: Line number 609

"summary": "ESBGBudgetSheet", "description": "Get the ESBGBudgetSheetObj", "operationId": "ESBudget_ESBGBudgetSheet",

[sriyen-msft]

@entersoftsa There is no metadata found in the swagger, Can you please go thru the instructions mentioned in the documentation to add metadata to your connector.

[entersoftsa]

@entersoftsa There is no metadata found in the swagger, Can you please go thru the instructions mentioned in the documentation to add metadata to your connector.

Hi Srikanth,
According to the documentation that you are referring to, the metadata for publisher and stackOwner should be located in the apiProperties.json file. This is where I have put those metadata (line 36 & 37 in the apiProperties.json file).

Should I also include them in the api Swagger definition file? If so, in which section should be put? There is no documentation for this or I missed it.
Thanks in advance

[sriyen-msft]

@entersoftsa There is no metadata found in the swagger, Can you please go thru the instructions mentioned in the documentation to add metadata to your connector.

Hi Srikanth,
According to the documentation that you are referring to, the metadata for publisher and stackOwner should be located in the apiProperties.json file. This is where I have put those metadata (line 36 & 37 in the apiProperties.json file).

Should I also include them in the api Swagger definition file? If so, in which section should be put? There is no documentation for this or I missed it.
Thanks in advance

Metadata in your connector files looks good. No change is required now.. Thanks

[entersoftsa]

Hi Srikanth,
I have uploaded a new version (0.7) of the api definitions, where I have addressed all the Summary / Description issues that you have mentioned in your latest review.