Skip to content

Conversation

@robrams
Copy link
Contributor

@robrams robrams commented Mar 27, 2019

No description provided.

@msftclas
Copy link

msftclas commented Mar 27, 2019

CLA assistant check
All CLA requirements met.

@JatinSanghvi
Copy link
Contributor

Are we supposed to add configFile.json too if needed, for example to change the tier to Standard from default Premium?

@mamurshe
Copy link
Contributor

I don't see the icon.png. Did you try creating a custom connector without the icon? I think it will fail.

@robrams
Copy link
Contributor Author

robrams commented Mar 28, 2019

I don't see the icon.png. Did you try creating a custom connector without the icon? I think it will fail.

Shyam said he didn't want us checking in any icon files, even the default one.

@robrams
Copy link
Contributor Author

robrams commented Mar 28, 2019

Are we supposed to add configFile.json too if needed, for example to change the tier to Standard from default Premium?

The configFile isn't something the people making the connectors need to be concerned with. It's just a stopgap until we have a better solution for gathering that data (the portal, CDS, etc).

@mamurshe mamurshe merged commit e166404 into master Mar 29, 2019
@mamurshe mamurshe deleted the robOpenSource branch April 1, 2019 22:11
Encodian added a commit to Encodian/PowerPlatformConnectors that referenced this pull request Mar 15, 2022
sriyen-msft pushed a commit that referenced this pull request Mar 16, 2022
* Encodian March 21 Release

* Encodian April 21 Release

* Encodian May 21 Release

* Encodian June 21 Release

* Encodian - June 21 Release #2

* Encodian - August Release #1

* Encodian - Nov 21 Release

* Encodian - Nov 21 Release #2

* Encodian March 22

* Encodian March 22 #2

* Encodian March 22 #3

* Encodian March 22 #4

* Encodian March 22 #5
ghost pushed a commit to recordedfuture/PowerPlatformConnectors that referenced this pull request Mar 28, 2022
* Encodian March 21 Release

* Encodian April 21 Release

* Encodian May 21 Release

* Encodian June 21 Release

* Encodian - June 21 Release microsoft#2

* Encodian - August Release #1

* Encodian - Nov 21 Release

* Encodian - Nov 21 Release microsoft#2

* Encodian March 22

* Encodian March 22 microsoft#2

* Encodian March 22 microsoft#3

* Encodian March 22 microsoft#4

* Encodian March 22 microsoft#5
sriyen-msft pushed a commit that referenced this pull request May 12, 2022
* Encodian March 21 Release

* Encodian April 21 Release

* Encodian May 21 Release

* Encodian June 21 Release

* Encodian - June 21 Release #2

* Encodian - August Release #1

* Encodian - Nov 21 Release

* Encodian - Nov 21 Release #2

* Encodian March 22

* Encodian March 22 #2

* Encodian March 22 #3

* Encodian March 22 #4

* Encodian March 22 #5

* March 22 Release (Updated)
v-EgorKozhadei pushed a commit that referenced this pull request Jul 14, 2022
* Encodian March 21 Release

* Encodian April 21 Release

* Encodian May 21 Release

* Encodian June 21 Release

* Encodian - June 21 Release #2

* Encodian - August Release #1

* Encodian - Nov 21 Release

* Encodian - Nov 21 Release #2

* Encodian March 22

* Encodian March 22 #2

* Encodian March 22 #3

* Encodian March 22 #4

* Encodian March 22 #5

* March 22 Release (Updated)

* Encodian - July 22
Encodian added a commit to Encodian/PowerPlatformConnectors that referenced this pull request Oct 26, 2022
Amjed-Ayoub pushed a commit that referenced this pull request Nov 8, 2022
* Encodian March 21 Release

* Encodian April 21 Release

* Encodian May 21 Release

* Encodian June 21 Release

* Encodian - June 21 Release #2

* Encodian - August Release #1

* Encodian - Nov 21 Release

* Encodian - Nov 21 Release #2

* Encodian March 22

* Encodian March 22 #2

* Encodian March 22 #3

* Encodian March 22 #4

* Encodian March 22 #5

* March 22 Release (Updated)

* Encodian Oct 22 Release

* Encodian October 22 Release #2

* Updates

* Minor update
wuqiten pushed a commit to wuqiten/PowerPlatformConnectors that referenced this pull request Dec 12, 2022
* Encodian March 21 Release

* Encodian April 21 Release

* Encodian May 21 Release

* Encodian June 21 Release

* Encodian - June 21 Release microsoft#2

* Encodian - August Release microsoft#1

* Encodian - Nov 21 Release

* Encodian - Nov 21 Release microsoft#2

* Encodian March 22

* Encodian March 22 microsoft#2

* Encodian March 22 microsoft#3

* Encodian March 22 microsoft#4

* Encodian March 22 microsoft#5

* March 22 Release (Updated)

* Encodian Oct 22 Release

* Encodian October 22 Release microsoft#2

* Updates

* Minor update
lindarecfut pushed a commit to recordedfuture/PowerPlatformConnectors that referenced this pull request Feb 14, 2023
* Encodian March 21 Release

* Encodian April 21 Release

* Encodian May 21 Release

* Encodian June 21 Release

* Encodian - June 21 Release microsoft#2

* Encodian - August Release #1

* Encodian - Nov 21 Release

* Encodian - Nov 21 Release microsoft#2

* Encodian March 22

* Encodian March 22 microsoft#2

* Encodian March 22 microsoft#3

* Encodian March 22 microsoft#4

* Encodian March 22 microsoft#5

* March 22 Release (Updated)

* Encodian - July 22
lindarecfut pushed a commit to recordedfuture/PowerPlatformConnectors that referenced this pull request Feb 14, 2023
* Encodian March 21 Release

* Encodian April 21 Release

* Encodian May 21 Release

* Encodian June 21 Release

* Encodian - June 21 Release microsoft#2

* Encodian - August Release #1

* Encodian - Nov 21 Release

* Encodian - Nov 21 Release microsoft#2

* Encodian March 22

* Encodian March 22 microsoft#2

* Encodian March 22 microsoft#3

* Encodian March 22 microsoft#4

* Encodian March 22 microsoft#5

* March 22 Release (Updated)

* Encodian Oct 22 Release

* Encodian October 22 Release microsoft#2

* Updates

* Minor update
sriharip-docusign referenced this pull request in release-docusign/PowerPlatformConnectors Apr 18, 2023
harshitav-docusign referenced this pull request in release-docusign/PowerPlatformConnectors Apr 21, 2023
Part 1: Get Tab values(UI only)
TobinWritesCode referenced this pull request in Bit-Quill/PowerPlatformConnectors Aug 22, 2024
* Update script.csx

- Fix null detection.

* Fix issue with null handling in Snowflake connector

---------

Co-authored-by: jbrinkman <github@brinkman.me>
vmanoharas pushed a commit that referenced this pull request Oct 3, 2024
* - First pass at getting all partitions. Still needs a few parameters setup so the code is currently broken. WIP.

* Update script.csx

Convert all partitions, not just the first one.

* Update script.csx

Fix placeholders of querystring params that need gotten/set for fetching subsequent partitions.

* Update script.csx

Fix syntax errors to ensure that isn't why connector upload is failing.

* Update script.csx

Fix more compilation errors.

* Update script.csx

Wanted a record of the fact that these changes are still returning subsequent partitions in array format, despite literally every response being converted.

Is there maybe some sort of caching of the connector behavior, because it seems like I can't ever get the behavior of my data flow to change at all...

* Update script.csx

This version of the connector is the most complete example that can successfully be uploaded as a custom connector.

Yet I still can't get the behavior to change no matter what code changes I make.

* Issue #5 - Null detection and Type Conversion Error (#1)

* Update script.csx

- Fix null detection.

* Fix issue with null handling in Snowflake connector

---------

Co-authored-by: jbrinkman <github@brinkman.me>

* Update apiDefinition.swagger.json

- This version of the swaggerjson SHOULD be working, but we are seeing the DataSchema object being flattened out once uploaded to customer connector.

* array data for DataSchema

Got the swagger right (was really the code was had checked in before with just a little cleanup.

The custom connector is now failing due to internal server error so we need to find a way to use the test page in powerapps online, despite the fact that it doesn't really handle array data very well. Possibly specifying the raw body data might be a workaround.

* Update script.csx

- Last few tweaks to get the customer connector to return subsequent partitions in pre-converted format.

* Add version information into readme documentation

* cleanup endpoints

- extra body element is required. Caused a whole mess of issues.
- change DataSchema to required and deprecate or delete unused endpoints as needed.
- Remove fetchAllPages feature and separate into its own branch.

* Code cleanup.

- Make log messages more accurate.
- Remove last remnant of fetchAllPartitions.

* code cleanup

* more minor code cleanup

* intermediate check in

- The code is acting absolutely insane and returning GetResults method as just a single property "Data" formatted as array. Since this is the 0 partition it should include metadata.
- The interface is also not showing the partition parameter for the execsql method, so something is borked.

* GetResults partition zero fixed

- This was a very subtle issue related to the fact that when you call GetResults operation for partition zero you have no request body, so it cannot be parsed as json.
- Change the response of execstmt async to match the schema of the sync version b/c the powerapps ui does not seem to be able to deal with the fact that async/sync have different response formats respectively.

* SPC-36: Handle unexpected async responses better (#5)

* Update script.csx

- Fix async detection based on response code instead of request params, b/c apparently snowflake API can decide to return an async response if a synchronous response takes too long to return.

* Fix typo in script.csx

"BeginFetch" misspelled

---------

Co-authored-by: Joseph Brinkman <github@brinkman.me>

* SPC-39: MULTI_STATEMENT_COUNT parameter was being ignored (#6)

* Update apiDefinition.swagger.json

- change parameter name case to match snowflake docs exactly

* add StatementHandles

Map new response property for multi-statement handling.

* Apply mappings to GetResults

Same statementHandles mapping that was previously added to ExecSql was applied to GetResults to support Async

* Remove async fixes

These changes are already in dev branch, it was just a temporary change for debugging.

* GetResults schema (#7)

Innacurate schema was causing compilation issues in the power apps. Better to leave it as a untyped object since the schema is dynamic.

* - Parse Object/Array types (#8)

They were represented as a string before.

* Document limitations per my experience. (#9)

* Document limitations per my experience.

* - Tweak readme

* Update language limitations in the Readme documentation.

---------

Co-authored-by: jbrinkman <github@brinkman.me>

* openapi spec validation errors (#10)

I was able to type the untyped objects, but a lot of those openapi spec validation errors are inherent to the fact that the snowflake api routes are technically all partial matches for eachother since the exec stmt path is "/"

* Updated version history

* Fix typo

---------

Co-authored-by: TobinWritesCode <tobin.chee@improving.com>
vmanoharas pushed a commit that referenced this pull request Jul 11, 2025
…#3920)

* FLOW-1429 Add integration test for PowerApps connector (#2)

* FLOW-1429 Add integration test for PowerApps connector #2

* FLOW-3900: Handling nulls and setup tests based on client id and secret

---------

Co-authored-by: Rafal Zukowski <rafal.zukowski@snowflake.com>

* FLOW-3900: Update summary with a fix description

* FLOW-1429 Update SnowflakeTestApp mock parameters  to use TestData (#5)

FLOW-1429 Update SnowflakeTestApp mock parameters  to use TestData

---------

Co-authored-by: Rafal Zukowski <rafal.zukowski@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants