Skip to content

Update Scrive eSign connector #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2020
Merged

Update Scrive eSign connector #458

merged 2 commits into from
Sep 23, 2020

Conversation

@marcusdelang
Copy link
Contributor

@marcusdelang marcusdelang commented Sep 21, 2020 •
edited
Loading

Please check the following conditions for your PR.

  • apiDefinition.swagger.json is validated using paconn validate command.
  • apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

@marcusdelang
Copy link
Contributor Author

marcusdelang commented Sep 21, 2020 •
edited
Loading

Swagger and Change Validation is failing due to a type being modified. The old type did not work so this has to be updated. This is expected and it is OK to merge it.

@sriyen-msft sriyen-msft merged commit d15a2be into microsoft:dev Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sriyen-msft sriyen-msft sriyen-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcusdelang @sriyen-msft