Set url/token with policy #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriyen-msft
suggested changes
Sep 11, 2020
| }, | ||
| { | ||
| "name": "peltarionbody", | ||
| "in": "header", |
There was a problem hiding this comment.
@andvra The summary and description says it is body parameter, but definition says "in":"header". If it is body parameter that expects json object, it should have "type":"object".
There was a problem hiding this comment.
Our platform expects body tags with a number of different structures, so it won't match a specific schema, which is required if we send this as a body. Therefore, we stringify the body and send it as a header parameter.
sriyen-msft
suggested changes
Sep 22, 2020
| "title": "Query token", | ||
| "parameters": { | ||
| "x-ms-apimTemplateParameter.name": "code", | ||
| "x-ms-apimTemplateParameter.value": "FHWJvOJnrrBz8v7DOWoABLS1K2e9Im6q7YalAthQMGkqTa57jDYm/w==", |
There was a problem hiding this comment.
@andvra It seems to be some shared key to access your service.
- Please note that this key is publicly visible to anyone.
- You may place into connection parameters (as url and token) and share the key with your customers explicitly
There was a problem hiding this comment.
Thanks for noting. The code isn't needed, so removed it from the code now.
sriyen-msft
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the following conditions for your PR.
apiDefinition.swagger.jsonis validated usingpaconn validatecommand.apiProperties.jsonhas a valid brand color. Invalid brand colors are#007ee5and#ffffff.