Skip to content

Conversation

@Blackbaud-BenLambert
Copy link
Contributor


Please check the following conditions for your PR.

  • apiDefinition.swagger.json is validated using paconn validate command.
  • apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

@Blackbaud-BenLambert Blackbaud-BenLambert requested a review from a team as a code owner August 13, 2020 21:02
@dougelliott
Copy link
Contributor

@Blackbaud-BenLambert Going forward we're asking partners to make PRs to the dev branch first, then we will handle getting those changes merged into master for them. Would you be able to re-create the PR for these changes into the dev branch?

@dougelliott
Copy link
Contributor

@Blackbaud-BenLambert Checking in on the above comment

@mamurshe mamurshe self-assigned this Sep 16, 2020
@mamurshe
Copy link
Contributor

@Blackbaud-BenLambert Checking in on the above comment

Waiting on this.

@sriyen-msft sriyen-msft merged commit 6c912a3 into microsoft:master Sep 17, 2020
@Blackbaud-BenLambert
Copy link
Contributor Author

@dougelliott @mamurshe sorry for the delay, been out for a few weeks moving out of state. Looks like this PR is closed - anything you still need me to do? Going forward, I'll send PRs to the dev branch.

@dougelliott
Copy link
Contributor

@Blackbaud-BenLambert Hope the move went well! All is good now, but yes, please do future PRs to the dev branch. Have a great weekend ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants