Skip to content

Conversation

@jkxyz
Copy link
Contributor

@jkxyz jkxyz commented Dec 4, 2024

Update the Nosco connector to expose additional fields.

@jkxyz jkxyz requested a review from a team as a code owner December 4, 2024 13:42
@vmanoharas
Copy link
Contributor

Hi @jkxyz,

Can you please correct the folder structure before proceeding the review?

image

@jkxyz
Copy link
Contributor Author

jkxyz commented Dec 5, 2024

Hi @vmanoharas

I see a number of errors in the CODEOWNERS file that are already present in the dev/master branch, related to users who seem to no longer exist. However, I do see that my change adds an additional error:

 Unknown owner on line 64: make sure @jkxyz exists and has write access to the repository 

Can this be remedied by giving me write access to the repo?

I've also updated my branch to add an extra newline at the end of that file. Other than that, the syntax of that file appears to be correct.

Do you need anything else before proceeding with your review?

@jkxyz
Copy link
Contributor Author

jkxyz commented Dec 9, 2024

Hi @vmanoharas,

Please let me know if you need any further changes to this PR before reviewing!

@vmanoharas
Copy link
Contributor

Hello @jkxyz,

This is your development branch, and you are responsible for managing it. Please correct the issue before we proceed with the review.

@jkxyz
Copy link
Contributor Author

jkxyz commented Dec 11, 2024

@vmanoharas Can you please be more specific about the issue that needs to be fixed? As far as I can tell, the directory structure is correct.

@vmanoharas
Copy link
Contributor

Hello @jkxyz,

Please look into the image below, the folder structure is not as expected. Please follow the instructions in the below link and remove the folders which are not required.

image

https://github.com/microsoft/PowerPlatformConnectors

Additionally, kindly review the below swagger validation errors and confirm/fix them if the existing flow will not be broken.

##[error]The output field has been added when additional properties are not allowed. This will break validation for existing flows. ValuePath: operation/GetIdea/responses/200/schema/fields Source: NewSwagger
##[error]The output field has been added when additional properties are not allowed. This will break validation for existing flows. ValuePath: operation/GetIdea/responses/200/schema/content Source: NewSwagger
##[error]The output field has been added when additional properties are not allowed. This will break validation for existing flows. ValuePath: operation/Ideas/responses/200/schema/nodes/items/fields Source: NewSwagger
##[error]The output field has been added when additional properties are not allowed. This will break validation for existing flows. ValuePath: operation/Ideas/responses/200/schema/nodes/items/content Source: NewSwagger

@vmanoharas
Copy link
Contributor

Additionally, observed one more commit showed in the below screenshot, this wouldn't be required to commit. Please revert the same to correct the folder structure.

image

@jkxyz
Copy link
Contributor Author

jkxyz commented Dec 16, 2024

Hi @vmanoharas

Thanks for taking the time to clarify for me!

Additionally, kindly review the below swagger validation errors and confirm/fix them if the existing flow will not be broken.

##[error]The output field has been added when additional properties are not allowed. This will break validation for existing flows. ValuePath: operation/GetIdea/responses/200/schema/fields Source: NewSwagger ##[error]The output field has been added when additional properties are not allowed. This will break validation for existing flows. ValuePath: operation/GetIdea/responses/200/schema/content Source: NewSwagger ##[error]The output field has been added when additional properties are not allowed. This will break validation for existing flows. ValuePath: operation/Ideas/responses/200/schema/nodes/items/fields Source: NewSwagger ##[error]The output field has been added when additional properties are not allowed. This will break validation for existing flows. ValuePath: operation/Ideas/responses/200/schema/nodes/items/content Source: NewSwagger

I can confirm that these additional fields are expected, and there are no breaking changes in the API or connector.

Additionally, observed one more commit showed in the below screenshot, this wouldn't be required to commit. Please revert the same to correct the folder structure.

image

I've removed this commit from the branch. I added it as described in the certification docs, to allow Nosco to manage future changes to our connector ourselves.

Is it possible to add me to the code owners for our connector in a separate PR?

Please let me know if further changes are required before merging.

@vmanoharas
Copy link
Contributor

Thank you @jkxyz for addressing the issues. After running the swagger validation recieved same errors. So I am approving this PR. Thank you for working with us.

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Partner,

Congratulations your PR is approved !! We are proud to announce the Brand-New Certification experience for you to certify Power Platform Copilot Connectors & Plugins. Read the blog here- Announcing Partner Center to certify and publish Power Platform Copilot Connectors and Plugins - Microsoft Power Platform Blog

As next steps:

  1. Learn about the new certification experience- Get your Power Platform connector and plugin certified - Overview
  2. Package your connector and plugin files- Prepare Power Platform connector and plugin files for certification
  3. Validate the package for structure before submitting the package for certification to Partner Center - Run Package Validator tool
  4. Initiate a certification request in Partner Center- Verified publisher certification process
  5. Ensure your connector & plugin files comply to the Marketplace policies here- 5000 Power Platform Connector Policies for Marketplace and also 1000 Marketplace policies(as applicable)
  6. Test your connector post certification to provide go-live for deployment- Testing Guidelines
  7. If you wish to Update your connector or plugin in future- Updating Guidelines

For any queries or concerns please get in touch with us on certificationteam@microsoft.com

Many thanks,
Power Platform
Copilot connector & plugin certification team

@vmanoharas vmanoharas merged commit 4ae0eb4 into microsoft:dev Dec 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants