Skip to content

Conversation

@SerranoAdrian
Copy link
Contributor

Pull request for Eden AI certified connector.

SDPCloud and others added 2 commits May 9, 2023 16:22
* Partner Center connector - new fields and deal registration actions (microsoft#2130)

* Update apiDefinition.swagger.json

* Latest changes

* fix format warning

* X-Caller_Id should be optional

* Update apiDefinition.swagger.json

Review changes -
->Added reg status and sub status fields.
->Update the fields descriptions as per api's details available on Microsoft public site.
->Remove submission related fields.
->Mark registration status field as read only.
->Remove offerId from root.
->Use Enum values in Create deal registration model.
->Create a separate model for update deal registration.
Create a separate action for update deal registration.

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

Add deprecate text in Update a referral by Id action

* Update apiDefinition.swagger.json

Connector status keep as Preview and UpdateReferralById deprecated keep as false but deprecated word in description.

* Update apiDefinition.swagger.json

update deal registration success message.

* Update apiDefinition.swagger.json

added title for registration object

* Bitskout Connector (microsoft#2140)

* Bitskout Connector

* Requested changes

* EC-14395 Make it so fields aren't required anymore for updates (microsoft#2150)

* Added orderby parameter

* Added orderby parameter

* feat: add x-ms-pageable extension

* feat: add updatenextlink policy instance

* refactor: whitespace refactoring

* Update apiProperties.json

* fix(EC-14395): Integrate the patch schema endpoint

* fix(EC-14395): Add specs for the schema endpoint's responses

* fix(EC-14395): Add required fields to the schema

Co-authored-by: Johannes Heesterman <johannes@elfsquad.io>
Co-authored-by: johannesheesterman <heestermanj@gmail.com>
Co-authored-by: Stan van Rooy <stanvanrooy6@gmail.com>

* ManageEngine ServiceDesk Plus Cloud app submission

* Categories and readme document updated

* Categories updated

---------

Co-authored-by: Farhan <103836444+94farhan@users.noreply.github.com>
Co-authored-by: saferoombiz <32263053+saferoombiz@users.noreply.github.com>
Co-authored-by: Tess Ellenoir Duursma <thomasduursma@outlook.com>
Co-authored-by: Johannes Heesterman <johannes@elfsquad.io>
Co-authored-by: johannesheesterman <heestermanj@gmail.com>
Co-authored-by: Stan van Rooy <stanvanrooy6@gmail.com>
Co-authored-by: Mahbub Murshed <48570820+mamurshe@users.noreply.github.com>
Co-authored-by: SDPCloud <tharanishanth16@gmail.com>
@SerranoAdrian SerranoAdrian requested a review from a team as a code owner May 12, 2023 09:35
@SerranoAdrian
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Eden AI"

@SerranoAdrian SerranoAdrian changed the title Edenai Edenai Certified Connector request May 12, 2023
Copy link
Contributor

@Amjed-Ayoub Amjed-Ayoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queSaDiLLaSS thank you so much for submitting your connector artifacts. May I ask you pease to update your branch and fix this PR. you are making changes to another connector.
image

@Amjed-Ayoub Amjed-Ayoub added certified-connector needs:partner-attention On Hold We are reviewing your connector with our management, until then your PR will be on hold. New For brand new connector submissions labels May 12, 2023
Copy link
Contributor Author

@SerranoAdrian SerranoAdrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The connector ServiceDeskPlus Cloud is not in the dev branch I don't know how I end up added it but it seems that deleting it is a solution ?

@Amjed-Ayoub Amjed-Ayoub added Validation phase Connector is being validated by Microsoft. and removed On Hold We are reviewing your connector with our management, until then your PR will be on hold. labels May 15, 2023
Correct title : Eden AI
Remove a white space in description
Add all required sections
Copy link
Contributor

@Amjed-Ayoub Amjed-Ayoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @queSaDiLLaSS ,
I hope you are doing well.
Congratulations, your pull request is approved and merged. Please submit the files to ISV Studio or update your submission using your latest commit ID, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio. Please make sure that the icon meets all the requirements, that it’s size is 230x230, icon background is not white or transparent and it matches the iconBrandColor property in apiProperties.json file.
After making the submission in ISV Studio, please attach an intro.md file in the activity control section. This file is required and it's different from readme.md. You can find an example of intro.md file on this page at step 6.
Please Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector.
We expect all tests to be completed within 1-2 weeks.
If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions.
Please let me know if you have any questions or run into any problems while creating or updating your submission.
Thank you very much for working with us.

@Amjed-Ayoub Amjed-Ayoub merged commit 116a22a into microsoft:dev May 16, 2023
@Amjed-Ayoub Amjed-Ayoub removed the Validation phase Connector is being validated by Microsoft. label May 16, 2023
@Amjed-Ayoub Amjed-Ayoub removed needs:partner-attention New For brand new connector submissions labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants