Add virus total certified #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add virus total certified
dougelliott
suggested changes
May 6, 2020
There was a problem hiding this comment.
@shschwar The settings.json and icon.png files are not necessary for open sourcing as part of certification, so please feel free to remove them.
That said, we do require that a readme.md be included as part of open sourcing. Please see the Azure Key Vault readme.md as an example.
added 2 commits
May 6, 2020 09:28
Add readme file, remove ICON and settings
ShyamSunder90
suggested changes
May 6, 2020
dougelliott
suggested changes
May 29, 2020
sriyen-msft
suggested changes
Jun 16, 2020
JatinSanghvi
suggested changes
Jun 17, 2020
sriyen-msft
suggested changes
Jun 26, 2020
There was a problem hiding this comment.
@shschwar Please fix the indentation of the swagger by removing extra spaces added each line
JatinSanghvi
reviewed
Jul 8, 2020
|
Followed up with the partner in certification portal to address the comments mentioned in the PR. |
|
all review are fix with commit from Jul 12, 2020 |
dougelliott
approved these changes
Aug 5, 2020
|
@JatinSanghvi @sriyen-msft Please take a look. |
sriyen-msft
suggested changes
Aug 12, 2020
sriyen-msft
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add virus total certified
This checklist is used to make sure that common guidelines for a pull request are followed.