Skip to content

Conversation

@tjkb
Copy link
Contributor

@tjkb tjkb commented Jan 5, 2023

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

94farhan and others added 6 commits November 11, 2022 12:01
…icrosoft#2130)

* Update apiDefinition.swagger.json

* Latest changes

* fix format warning

* X-Caller_Id should be optional

* Update apiDefinition.swagger.json

Review changes -
->Added reg status and sub status fields.
->Update the fields descriptions as per api's details available on Microsoft public site.
->Remove submission related fields.
->Mark registration status field as read only.
->Remove offerId from root.
->Use Enum values in Create deal registration model.
->Create a separate model for update deal registration.
Create a separate action for update deal registration.

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

Add deprecate text in Update a referral by Id action

* Update apiDefinition.swagger.json

Connector status keep as Preview and UpdateReferralById deprecated keep as false but deprecated word in description.

* Update apiDefinition.swagger.json

update deal registration success message.

* Update apiDefinition.swagger.json

added title for registration object
* Bitskout Connector

* Requested changes
…soft#2150)

* Added orderby parameter

* Added orderby parameter

* feat: add x-ms-pageable extension

* feat: add updatenextlink policy instance

* refactor: whitespace refactoring

* Update apiProperties.json

* fix(EC-14395): Integrate the patch schema endpoint

* fix(EC-14395): Add specs for the schema endpoint's responses

* fix(EC-14395): Add required fields to the schema

Co-authored-by: Johannes Heesterman <johannes@elfsquad.io>
Co-authored-by: johannesheesterman <heestermanj@gmail.com>
Co-authored-by: Stan van Rooy <stanvanrooy6@gmail.com>
@Amjed-Ayoub
Copy link
Contributor

Hello @tjkb,
I hope you are doing well.
Congratulations, your pull request is approved and merged. Please submit the files to ISV Studio or update your submission using your latest commit ID, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio. Please make sure that the icon meets all the requirements, that it’s size is 230x230, icon background is not white or transparent and it matches the iconBrandColor property in apiProperties.json file.
After making the submission in ISV Studio, please attach an intro.md file in the activity control section. This file is required and it's different from readme.md. You can find an example of intro.md file on this page at step 6.
Please Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector.
We expect all tests to be completed within 1-2 weeks.
If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions.
Please let me know if you have any questions or run into any problems while creating or updating your submission.
Thank you very much for working with us.

@Amjed-Ayoub Amjed-Ayoub removed Validation phase Connector is being validated by Microsoft. needs:partner-attention labels Jan 6, 2023
@tjkb
Copy link
Contributor Author

tjkb commented Jan 13, 2023

@Amjed-Ayoub thanks for approving but the pr is not merged. Please merge it so that I can proceed with the submission in the ISV studio, thx

Copy link
Contributor

@Amjed-Ayoub Amjed-Ayoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjkb you are merging your changes to our master branch. this is not allowed. please make sure to push your changes to our microsoft:dev branch.
image

@tjkb tjkb changed the base branch from master to dev January 16, 2023 06:37
@tjkb tjkb requested a review from a team as a code owner January 16, 2023 06:37
@tjkb
Copy link
Contributor Author

tjkb commented Jan 16, 2023

@Amjed-Ayoub thanks for the help, now it should be all correct. Please take another look

@Amjed-Ayoub
Copy link
Contributor

@tjkb Please submit the files to ISV Studio or update your submission using your latest commit ID

@Amjed-Ayoub Amjed-Ayoub merged commit b8726d0 into microsoft:dev Jan 18, 2023
lindarecfut pushed a commit to recordedfuture/PowerPlatformConnectors that referenced this pull request Feb 14, 2023
* Partner Center connector - new fields and deal registration actions (microsoft#2130)

* Update apiDefinition.swagger.json

* Latest changes

* fix format warning

* X-Caller_Id should be optional

* Update apiDefinition.swagger.json

Review changes -
->Added reg status and sub status fields.
->Update the fields descriptions as per api's details available on Microsoft public site.
->Remove submission related fields.
->Mark registration status field as read only.
->Remove offerId from root.
->Use Enum values in Create deal registration model.
->Create a separate model for update deal registration.
Create a separate action for update deal registration.

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

Add deprecate text in Update a referral by Id action

* Update apiDefinition.swagger.json

Connector status keep as Preview and UpdateReferralById deprecated keep as false but deprecated word in description.

* Update apiDefinition.swagger.json

update deal registration success message.

* Update apiDefinition.swagger.json

added title for registration object

* Bitskout Connector (microsoft#2140)

* Bitskout Connector

* Requested changes

* EC-14395 Make it so fields aren't required anymore for updates (microsoft#2150)

* Added orderby parameter

* Added orderby parameter

* feat: add x-ms-pageable extension

* feat: add updatenextlink policy instance

* refactor: whitespace refactoring

* Update apiProperties.json

* fix(EC-14395): Integrate the patch schema endpoint

* fix(EC-14395): Add specs for the schema endpoint's responses

* fix(EC-14395): Add required fields to the schema

Co-authored-by: Johannes Heesterman <johannes@elfsquad.io>
Co-authored-by: johannesheesterman <heestermanj@gmail.com>
Co-authored-by: Stan van Rooy <stanvanrooy6@gmail.com>

* Update connector

* format

* add contact & metadata

* Valid privacy policy url

* Revert

Co-authored-by: Farhan <103836444+94farhan@users.noreply.github.com>
Co-authored-by: saferoombiz <32263053+saferoombiz@users.noreply.github.com>
Co-authored-by: Tess Ellenoir Duursma <thomasduursma@outlook.com>
Co-authored-by: Johannes Heesterman <johannes@elfsquad.io>
Co-authored-by: johannesheesterman <heestermanj@gmail.com>
Co-authored-by: Stan van Rooy <stanvanrooy6@gmail.com>
Co-authored-by: Till Jakob <till@aheadintranet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants