- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.4k
Add new field in ahead connector #2270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…icrosoft#2130) * Update apiDefinition.swagger.json * Latest changes * fix format warning * X-Caller_Id should be optional * Update apiDefinition.swagger.json Review changes - ->Added reg status and sub status fields. ->Update the fields descriptions as per api's details available on Microsoft public site. ->Remove submission related fields. ->Mark registration status field as read only. ->Remove offerId from root. ->Use Enum values in Create deal registration model. ->Create a separate model for update deal registration. Create a separate action for update deal registration. * Update apiDefinition.swagger.json * Update apiDefinition.swagger.json Add deprecate text in Update a referral by Id action * Update apiDefinition.swagger.json Connector status keep as Preview and UpdateReferralById deprecated keep as false but deprecated word in description. * Update apiDefinition.swagger.json update deal registration success message. * Update apiDefinition.swagger.json added title for registration object
* Bitskout Connector * Requested changes
…soft#2150) * Added orderby parameter * Added orderby parameter * feat: add x-ms-pageable extension * feat: add updatenextlink policy instance * refactor: whitespace refactoring * Update apiProperties.json * fix(EC-14395): Integrate the patch schema endpoint * fix(EC-14395): Add specs for the schema endpoint's responses * fix(EC-14395): Add required fields to the schema Co-authored-by: Johannes Heesterman <johannes@elfsquad.io> Co-authored-by: johannesheesterman <heestermanj@gmail.com> Co-authored-by: Stan van Rooy <stanvanrooy6@gmail.com>
| Hello @tjkb, | 
| @Amjed-Ayoub thanks for approving but the pr is not merged. Please merge it so that I can proceed with the submission in the ISV studio, thx | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tjkb you are merging your changes to our master branch. this is not allowed. please make sure to push your changes to our microsoft:dev branch.

| @Amjed-Ayoub thanks for the help, now it should be all correct. Please take another look | 
| @tjkb Please submit the files to ISV Studio or update your submission using your latest commit ID | 
* Partner Center connector - new fields and deal registration actions (microsoft#2130) * Update apiDefinition.swagger.json * Latest changes * fix format warning * X-Caller_Id should be optional * Update apiDefinition.swagger.json Review changes - ->Added reg status and sub status fields. ->Update the fields descriptions as per api's details available on Microsoft public site. ->Remove submission related fields. ->Mark registration status field as read only. ->Remove offerId from root. ->Use Enum values in Create deal registration model. ->Create a separate model for update deal registration. Create a separate action for update deal registration. * Update apiDefinition.swagger.json * Update apiDefinition.swagger.json Add deprecate text in Update a referral by Id action * Update apiDefinition.swagger.json Connector status keep as Preview and UpdateReferralById deprecated keep as false but deprecated word in description. * Update apiDefinition.swagger.json update deal registration success message. * Update apiDefinition.swagger.json added title for registration object * Bitskout Connector (microsoft#2140) * Bitskout Connector * Requested changes * EC-14395 Make it so fields aren't required anymore for updates (microsoft#2150) * Added orderby parameter * Added orderby parameter * feat: add x-ms-pageable extension * feat: add updatenextlink policy instance * refactor: whitespace refactoring * Update apiProperties.json * fix(EC-14395): Integrate the patch schema endpoint * fix(EC-14395): Add specs for the schema endpoint's responses * fix(EC-14395): Add required fields to the schema Co-authored-by: Johannes Heesterman <johannes@elfsquad.io> Co-authored-by: johannesheesterman <heestermanj@gmail.com> Co-authored-by: Stan van Rooy <stanvanrooy6@gmail.com> * Update connector * format * add contact & metadata * Valid privacy policy url * Revert Co-authored-by: Farhan <103836444+94farhan@users.noreply.github.com> Co-authored-by: saferoombiz <32263053+saferoombiz@users.noreply.github.com> Co-authored-by: Tess Ellenoir Duursma <thomasduursma@outlook.com> Co-authored-by: Johannes Heesterman <johannes@elfsquad.io> Co-authored-by: johannesheesterman <heestermanj@gmail.com> Co-authored-by: Stan van Rooy <stanvanrooy6@gmail.com> Co-authored-by: Till Jakob <till@aheadintranet.com>
apiDefinition.swagger.json, by runningpaconn validatecommand.apiProperties.jsonhas a valid brand color and doesn't use an invalid brand color,#007ee5or#ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: