Fix XML parsing logic regression in the trigger response parsing code #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfix for FLOW 143: Update connect schema to 2.0 (JSON SIM)
…or & Intermediary
* Remove custom fields * Update dropdown labels to match with NDSE
… recipients are specified Instead, present the user with option to add recipient name, email
… , so that it shows in the UI output
…mail subject" and "Email body" from the user
Show options for setting recipient type and support 'in person signer' recipient type in the add recipient flow step
Version add recipient
# Conflicts: # certified-connectors/DocuSignDemo/apiDefinition.swagger.json # certified-connectors/DocuSignDemo/script.csx
…g template" and "create envelope" actions List custom fields shows up as an enum
# Conflicts: # certified-connectors/DocuSignDemo/apiDefinition.swagger.json
…ut selecting Workflow IDV
…il fast in case of user error
FLOW 200 : Error checking in case meta data for chosen verification type is missing
Merge SMS related code changes from Angel + Custom field bug fixes
xml parsing logic was missing
depfeife-msft
approved these changes
Oct 4, 2022
lindarecfut
pushed a commit
to recordedfuture/PowerPlatformConnectors
that referenced
this pull request
Feb 14, 2023
…microsoft#2025) * FLOW-78: Support for adding recipient type in the add recipient action * add core required param for add recipient - param name : custom fields * Add custom fields to recipient * Support setting core params for all signer types * Support for inperson signer recipient type * Update response to fit schema for in person signer * New schema changs for connec 2.0 json sim * Update model to recognize Connect SIM 2.0 format * add custom fields to the webhook response model * Update webhook response transformation logic for connect 2.0 json sim format * FLOW-133: Support recipient types Agent, CC, Certified Delivery, Editor & Intermediary * Add recipient step has following 2 changes. * Remove custom fields * Update dropdown labels to match with NDSE * FLOW-136: Support witness recipient type * FLOW-84: Create envelope from template expects input for body when no recipients are specified Instead, present the user with option to add recipient name, email * Tag the recipient id field returned by add recipient step "important" , so that it shows in the UI output * In case recipient roles are not specified in the template, request "Email subject" and "Email body" from the user * Fix whitespaces * Make the connect trigger changes backward compatible using versioning * Keep the previous version of operation id the same for create envelope using template action * Update name for send envelope using template * Add custom fields to "create envelope using template" FLOW action * Extract parsing custom fields to a separate method * Use a prefix to differentiate between text custom field and list custom field * FLOW-159: enable user to set label for tabs, in the add recipient tabs step * FLOW-180: Version "add recipient to an envelope" action * Remove duplicated method * FLOW-184: Support adding list custom fields for "create envelope using template" and "create envelope" actions List custom fields shows up as an enum * FLOW-168: list custom fields missing in the connect response * Rename custom fields variable name * Fix merge conflicts * Move the login information code block to where it was * FLOW-200: IDV Workflow IDV is a mandatory field but flow saving without selecting Workflow IDV * Throw 400 BadRequest instead of InternalException to make the flow fail fast in case of user error * shorten the custom field suffix to allow for longer field names * Fix setting up phone authentication * FLOW-213: Merge sms related code changes from Angel * Change the field type of country code and phone number to integer * FLOW-225: Trigger do not work after connector upgrade from 2.0 to 2.1 xml parsing logic was missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json, by runningpaconn validatecommand.apiProperties.jsonhas a valid brand color and doesn't use an invalid brand color,#007ee5or#ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: