Skip to content

Conversation

@RjImpx
Copy link
Contributor

@RjImpx RjImpx commented May 31, 2022


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

RjImpx and others added 30 commits October 26, 2020 11:17
- Changed to API key Authentication
- Added policy to set host
1. New Action Added
2. Updated response objects, these were missing
3. Updated parameter descriptions and summary
Trying to fix merge errors
Fixed question mark in summary
Impx connector updates.
Fix Warnings and bug with data types on OrganizationData Model
Revert "Fix Warnings and types on OrganizationData Model"
Fix datatype bug and warnings
fix name for emailAddress property of CustomerRequestPayload
RjImpx and others added 22 commits January 5, 2022 16:36
List Pending User Tasks by User ID or Email
List of Completed User Tasks by User ID or Email
Get Customer Notification Count
Get Rooms
Add Category to an Event Session
Add Presentation Topic to an Event Session
Adds One or More Speakers to a Session or Event
Add Room to Venue
Adds a New Speaker Type
List of All Prospect Lists
Get All Open Orders for an Individual
Get Speakers by Session
Get Speakers by Event
List All Event Cancellations by Event
Get Individual Custom Field Values (add to Update Individual Custom Field Values)
Add Nominee
Add or Update a List of Custom Fields Per Organization
Upload Picture for an Organization
Get Events by Session
Get Purchases for an Individual
List of Merchandise
List of Membership Types
Find Members by Name
Update Picture
Add Exam Scores
Get Course Attendees
List all courses
List Registrants
List of Publications
List of Sponsorships
List of Subcriptions
Get Tracks by Event
Get Event Waitlist
List All Opportunities
List of Exams
List All Exhibitors
Get Presentation Topic by Session
Get a list of All Speaker Types
Add Prospect



ProspectData
ExhibitorData
ExamData
OpportunityData
SubscriptionTypeData
SponsorshipData
PublicationTypeData
RegistrantData
CourseData
CourseAttendeeData
ExamScoreResultData
ExamScoreData
ContactData
MembershipTypeData
MerchandiseData
PurchasedItemData
SessionData
ContactImageData
CustomFieldValueData (add this to Add or Update a List of Custom Fields per Individual____)
CommitteeNomineeSaveData
RegistrantCancellationData
SpeakerData
PayableOrderData
ProspectListData
SpeakerTypeData
SpeakerSaveData
PresentationTopicData
TrackData
RoomData
List Pending User Tasks by User ID or Email
List of Completed User Tasks by User ID or Email
Get Customer Notification Count
Get Rooms
Add Category to an Event Session
Add Presentation Topic to an Event Session
Adds One or More Speakers to a Session or Event
Add Room to Venue
Adds a New Speaker Type
List of All Prospect Lists
Get All Open Orders for an Individual
Get Speakers by Session
Get Speakers by Event
List All Event Cancellations by Event
Get Individual Custom Field Values (add to Update Individual Custom Field Values)
Add Nominee
Add or Update a List of Custom Fields Per Organization
Upload Picture for an Organization
Get Events by Session
Get Purchases for an Individual
List of Merchandise
List of Membership Types
Find Members by Name
Update Picture
Add Exam Scores
Get Course Attendees
List all courses
List Registrants
List of Publications
List of Sponsorships
List of Subcriptions
Get Tracks by Event
Get Event Waitlist
List All Opportunities
List of Exams
List All Exhibitors
Get Presentation Topic by Session
Get a list of All Speaker Types
Add Prospect

ProspectData
ExhibitorData
ExamData
OpportunityData
SubscriptionTypeData
SponsorshipData
PublicationTypeData
RegistrantData
CourseData
CourseAttendeeData
ExamScoreResultData
ExamScoreData
ContactData
MembershipTypeData
MerchandiseData
PurchasedItemData
SessionData
ContactImageData
CustomFieldValueData (add this to Add or Update a List of Custom Fields per Individual____)
CommitteeNomineeSaveData
RegistrantCancellationData
SpeakerData
PayableOrderData
ProspectListData
SpeakerTypeData
SpeakerSaveData
PresentationTopicData
TrackData
RoomData
Removed some new actions to reduce file size
…onship to individual action, change visibility of some internal parameters
Paid Purchase trigger, Fix spaces in parameter names, Fix date vs date-time
@RjImpx RjImpx requested a review from a team as a code owner May 31, 2022 11:47
@Amjed-Ayoub Amjed-Ayoub added the Validation phase Connector is being validated by Microsoft. label Jun 3, 2022
@v-EgorKozhadei v-EgorKozhadei removed the Validation phase Connector is being validated by Microsoft. label Jun 6, 2022
@v-EgorKozhadei
Copy link
Contributor

Hello @RjImpx,

I hope you are doing well.

Congratulations, your pull request is approved and merged. Please submit the files to ISV Studio using your latest commit id, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio.

Please Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector.

We expect all tests to be completed within 1-2 weeks.

If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions.

Please let me know if you have any questions.

Thank you very much for working with us.

@v-EgorKozhadei v-EgorKozhadei merged commit e1ccea4 into microsoft:dev Jun 6, 2022
lindarecfut pushed a commit to recordedfuture/PowerPlatformConnectors that referenced this pull request Feb 14, 2023
…icrosoft#1699)

* Update Icon brand color

* Change to API Key Authentication

- Changed to API key Authentication
- Added policy to set host

* New Action and fix responses and descriptions

1. New Action Added
2. Updated response objects, these were missing
3. Updated parameter descriptions and summary

* Trying to fix merge errors

Trying to fix merge errors

* Fixed question mark in summary

Fixed question mark in summary

* Fix /api/v1/Individuals response user schema

* Add /api/v1/Customers/{pageNumber} response schema, update title & summary

* Add /api/v1/Individuals/{id}/Customfields response schema

* Fix properties description, visibility, types

* Revert "Add /api/v1/Individuals/{id}/Customfields response schema"

This reverts commit b38badc.

* Update responses Title and Description

* Fix Paconn Validate warnings

* Fix types in OrganizationData model

* Revert "Fix Warnings and types on OrganizationData Model"

* Update apiDefinition.swagger.json

Fix datatype bug and warnings

* Added four new trigger : CommitteeMemberUpdated,PurchaseCancelled,RequestUpdated and EmailUpdated

* Updated ProductPurchased Trigger description and added ref to ProductPurchasedPayload

* Update apiDefinition.swagger.json

fix name for emailAddress property of CustomerRequestPayload

* Added punctuation and spaces between words to descriptions

* Added missing Titles

* Add new actions

- Add new actions
- Fix 'primary' field texts
- Multiple fixes

* Fix "Cancelled" typo

* Remove references to PowerAutomate name

* Update apiDefinition.swagger.json

Fix format for Date type input parameters

* Revert "Fix format for Date type input parameters"

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

I removed the action "List all Organization" since there are internal decisions that are needing to be made.

* Next 5 Actions

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

* PR 3

References: (8)
PhoneDataset
PhoneSaveData
EventData
MembershipData
CustomFieldData
CommitteeMemberData
RegistrationData
RelationshipData

Actions: (10)
Get All Events
Get Organization Active Memberships
Get Organization Custom Field Values
Get Committee Information for an Individual
Add Phone to Individual
Get Individual Active Memberships
Get All Event Registrations Information for an Individual
Get Individual's Relationships
Update an Individual Email
Save Relationship for Organization

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

got it to validate successfully, but has warnings of similar paths.

* Update apiDefinition.swagger.json

* Add files via upload

* Delete apiDefinition.swagger.json

* Update apiDefinition.swagger.json

Made changes, waiting for verdict on response schema for Add or Update a list of Custom Fields Per Individual, on whether to keep empty, troubleshoot, or omit from PR

* Update apiDefinition.swagger.json

* Microsoft Pull Request Changes

Indentation changes and Removal of Empty response Schema.

* Update apiDefinition.swagger.json

* Used JSON Beautifier as suggested

* JSON Beautifier to have same format as Microsoft-PR

* Removed Schema

* Update apiDefinition.swagger.json

* PR5

Actions:
Delete an Individual Web Link
Add Web Link for Individual
Add Phone to Organization
Update Phone for an Organization
Update Phone for an Individual
Get a List of All Services of an Organization
Add a Service to an Organization
Find Members (Individuals) by Name
Get a List of Licenses
List All Awards

References:
RelationshipSaveData
ServiceData
LicenseData
AwardData

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

Actions:
Get a List of Licenses
Register an Individual for a Free Session
Add Activity to Organization
Get Individual Inactive Memberships
Get List of Active Certications for an Individual
Get List of Active Certications for an Organization
List All Individual Members
Add a New Task
Add Categories for an Individual
Add Notification to Individual
Delete a Category for an Individual
Assign Task to a User
Find member (Individuals) by last name
Find Members (Individuals) by first name
Update User Task Progress or Mark as Completed
Delete Record From Custom Data Table
Get Organization Inactive Memberships
List all Open Customer Request
List of Customer Relationships

References:
RelationshipTypeData
RequestData
UserTaskData
NotificationData
SaveCategoryBasicData
TaskData
TaskSaveData
CertificationData
Activity Data
SessionRegistrationData
LicenseData

* Add Customer.CustomFieldValueUpdated trigger

* Add Customer.Merged trigger

* Add Customer.RelationshipUpdated trigger

* Add Customer.PhoneUpdated trigger

* Add Event.Registration.Substituted trigger

* Fix Customer.PhoneUpdated summary

* Add Individual.RequestToBeForgotten trigger

* Add Customer.AddressUpdated trigger

* Add missing space to Customer.PhoneUpdated summary

* Add Individual.Deleted trigger

* Reorder trigger, refactor IndividualCreated parameters, fix Customer.AddressUpdated operation id

* Remove enum options, make text styles consistent

* Update apiDefinition.swagger.json

Fix typo

* Remove empty schemas, remove filters from webhooks that don't use them

* Removed Blank Schema- Microsoft PR

* PR 7

Add Category to an Organization
Add Customer Request
Update Customner Request
Delete a Category for an Organization
Get a List of All Notifications
List all Exhibits
Change the Password of a User
Get all states by country
Get Membership Stats by City
Get Membership Stats by State
List all Countries
Send Password Reset Link
Update Task by Task Number
Add Activity to Sales Opportunity
Add Note to Sales Opportunity


RequestSaveData
RequestUpdateData
ExhibitData
PasswordData
StateProvinceData
CityData
MembershipStatsStateData
CountryData
BaseNoteData

* Removed 5 actions

Get a List of All Notifications
Change the Password of a User
Get Membership Stats by City
Get Membership Stats by State
Send Password Reset Link

* Update-custom-field-value

* PR  8 items


List Pending User Tasks by User ID or Email
List of Completed User Tasks by User ID or Email
Get Customer Notification Count
Get Rooms
Add Category to an Event Session
Add Presentation Topic to an Event Session
Adds One or More Speakers to a Session or Event
Add Room to Venue
Adds a New Speaker Type
List of All Prospect Lists
Get All Open Orders for an Individual
Get Speakers by Session
Get Speakers by Event
List All Event Cancellations by Event
Get Individual Custom Field Values (add to Update Individual Custom Field Values)
Add Nominee
Add or Update a List of Custom Fields Per Organization
Upload Picture for an Organization
Get Events by Session
Get Purchases for an Individual
List of Merchandise
List of Membership Types
Find Members by Name
Update Picture
Add Exam Scores
Get Course Attendees
List all courses
List Registrants
List of Publications
List of Sponsorships
List of Subcriptions
Get Tracks by Event
Get Event Waitlist
List All Opportunities
List of Exams
List All Exhibitors
Get Presentation Topic by Session
Get a list of All Speaker Types
Add Prospect



ProspectData
ExhibitorData
ExamData
OpportunityData
SubscriptionTypeData
SponsorshipData
PublicationTypeData
RegistrantData
CourseData
CourseAttendeeData
ExamScoreResultData
ExamScoreData
ContactData
MembershipTypeData
MerchandiseData
PurchasedItemData
SessionData
ContactImageData
CustomFieldValueData (add this to Add or Update a List of Custom Fields per Individual____)
CommitteeNomineeSaveData
RegistrantCancellationData
SpeakerData
PayableOrderData
ProspectListData
SpeakerTypeData
SpeakerSaveData
PresentationTopicData
TrackData
RoomData

* Returned missing trigger info

List Pending User Tasks by User ID or Email
List of Completed User Tasks by User ID or Email
Get Customer Notification Count
Get Rooms
Add Category to an Event Session
Add Presentation Topic to an Event Session
Adds One or More Speakers to a Session or Event
Add Room to Venue
Adds a New Speaker Type
List of All Prospect Lists
Get All Open Orders for an Individual
Get Speakers by Session
Get Speakers by Event
List All Event Cancellations by Event
Get Individual Custom Field Values (add to Update Individual Custom Field Values)
Add Nominee
Add or Update a List of Custom Fields Per Organization
Upload Picture for an Organization
Get Events by Session
Get Purchases for an Individual
List of Merchandise
List of Membership Types
Find Members by Name
Update Picture
Add Exam Scores
Get Course Attendees
List all courses
List Registrants
List of Publications
List of Sponsorships
List of Subcriptions
Get Tracks by Event
Get Event Waitlist
List All Opportunities
List of Exams
List All Exhibitors
Get Presentation Topic by Session
Get a list of All Speaker Types
Add Prospect

ProspectData
ExhibitorData
ExamData
OpportunityData
SubscriptionTypeData
SponsorshipData
PublicationTypeData
RegistrantData
CourseData
CourseAttendeeData
ExamScoreResultData
ExamScoreData
ContactData
MembershipTypeData
MerchandiseData
PurchasedItemData
SessionData
ContactImageData
CustomFieldValueData (add this to Add or Update a List of Custom Fields per Individual____)
CommitteeNomineeSaveData
RegistrantCancellationData
SpeakerData
PayableOrderData
ProspectListData
SpeakerTypeData
SpeakerSaveData
PresentationTopicData
TrackData
RoomData

* Changes to PR 8

* Add items and changed $ref

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

* IMPX - Add Purchase Paid trigger

* IMPX - Update boolean properties, remove unnecesary required: false, default: false, enum for boolean types

* fix whitespaces in querystrings, add missing parameters to add relationship to individual action, change visibility of some internal parameters

* update date formats

* fix education credits format and description

Co-authored-by: William Llanos <williama.llanos@hotmail.com>
Co-authored-by: Fabio Vides F <11657124+fdjvf@users.noreply.github.com>
Co-authored-by: Fabio Vides F <fabio.vides@outlook.com>
Co-authored-by: Fabio Vides F <fvides@impexium.com>
Co-authored-by: jokano12 <83984082+jokano12@users.noreply.github.com>
Co-authored-by: jokano12 <jokano@optimumcs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants