Skip to content

Conversation

@mitanshug
Copy link
Contributor

@mitanshug mitanshug commented May 28, 2022

Images

Screenshot_RegEx_CreateFlow_001

Screenshot_RegEx_CreateFlow_002

Screenshot_RegEx_ActionList

Screenshot_RegEx_SuccessResult_001

Screenshot_RegEx_SuccessResult_002

Screenshot_RegEx_CreateFlow_003

Screenshot_RegEx_SuccessResult_003

Screenshot_RegEx_TestCLI


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@mitanshug mitanshug requested a review from a team as a code owner May 28, 2022 21:52
@ghost
Copy link

ghost commented May 28, 2022

CLA assistant check
All CLA requirements met.

mitanshug added 3 commits May 29, 2022 09:35
Uploaded apiProperties.json and apiDefinition.swagger.json
Added section for limitations and exclusions
@v-EgorKozhadei
Copy link
Contributor

v-EgorKozhadei commented May 30, 2022

Hi @happyume!

Thank you for your submission!

Your PR is missing screenshots from Test operations section, can you please add them?
You can refer to other open Independent Published PRs as an example.

Please let me know if you have any questions!

mitanshug added 3 commits May 30, 2022 19:28
Added five screenshot files from Power Automate using this connector.
Screenshot from Test operations section of custom connector UI
@mitanshug
Copy link
Contributor Author

mitanshug commented May 31, 2022

Hi @v-EgorKozhadei
I have now uploaded all the screenshots as required.
Please can you review.
Thanks

@natalie-pienkowska
Copy link
Contributor

Hi @happyume thanks so much for your contribution :) If you've submitted all the connector artifacts and feel ready for certification, please remove "Proposal" from your pull request title.

@mitanshug mitanshug changed the title Proposal - RegEx Matching (Independent Publisher) RegEx Matching (Independent Publisher) May 31, 2022
@mitanshug
Copy link
Contributor Author

Hi @natalie-pienkowska - The title is now updated to remove the word proposal. Thanks for the reminder :)

@v-EgorKozhadei
Copy link
Contributor

Hi again @happyume! Can you please remove the screenshots from the changed files and add them as images to the PR description? Screenshots from Test operations section are usually added here, not to the connector files. Sorry that I didn't mention it in my previous comments!

Copy link
Contributor

@v-EgorKozhadei v-EgorKozhadei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @happyume! Please check the comments after the review, thank you!

@v-EgorKozhadei v-EgorKozhadei added the Validation phase Connector is being validated by Microsoft. label Jun 3, 2022
mitanshug added 10 commits June 3, 2022 21:03
Removed starting whitespace from propertyValue for Category and changed description of 200 response to "request processed OK"
Added section on obtaining credentials and general formatting
Added images in its own directory
File has been re-uploaded to a sub-directory
File has been re-uploaded to a sub-directory
File has been re-uploaded to a sub-directory
File has been re-uploaded to a sub-directory
File has been re-uploaded to a sub-directory
@mitanshug
Copy link
Contributor Author

Hi @v-EgorKozhadei - Thank-you for advising me of the corrections to be done. I have now updated as per your comments. Please can you let me know if any further changes are needed.

@v-EgorKozhadei
Copy link
Contributor

Hi @happyume! Thank you very much for all the updates!
Can you please add the screenshots to the PR description and remove it from the folder with connector files?
The files changed tab contains 11 files, we need only 3: apiProperties.json, apiDefinition.swagger.json and readme.md.

You can refer to this PR for an example. The screenshots in this one are in PR's description and the connector folder contains only 3 files.

Please let me know if you have any questions or need help!

@mitanshug
Copy link
Contributor Author

Hi @v-EgorKozhadei - I have now deleted the sub-directory images (with 8 screenshots) and loaded them in this Pull Request description (first post at the top).

@v-EgorKozhadei
Copy link
Contributor

Hi @happyume! Thanks a lot for all the updates!

I'd like to ask you for one more fix before we can proceed to the next step.
Can you please rename the connector folder from Proposal - RegEx Matching (Independent Publisher) to just RegEx Matching?

@mitanshug
Copy link
Contributor Author

Hi @v-EgorKozhadei - I have created a different directory (without the word Proposal) with the reviewed files and deleted the directory which had the word Proposal

@v-EgorKozhadei
Copy link
Contributor

v-EgorKozhadei commented Jun 6, 2022

Hi @happyume! Thanks a lot for the changes! Can you please also remove the (Independent Publisher) part as well? So that the folder name will be just RegEx Matching.

The format of Proposal - RegEx Matching (Independent Publisher) is used for PR titles, and connector folder name is usually just connector name.

@mitanshug
Copy link
Contributor Author

Hi @v-EgorKozhadei - Apologies, I misunderstood. This is now fixed.

@v-EgorKozhadei
Copy link
Contributor

[[certify-connector]]

@v-EgorKozhadei
Copy link
Contributor

Hi @happyume,

Congratulations, your connector is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.

Please let us know if you have any questions.

Thank you very much for working with us.

@Amjed-Ayoub
Copy link
Contributor

Hello @happyume,
I hope you are doing well.
Your connector is in production deployment and queued up for the next deployment schedule. This process typically takes 3-4 weeks. Please note that the documentation for your connector will not be generated until the deployment process is in the final steps.
Please let us know if you have any questions.
Thank you very much for working with us.

@sriyen-msft
Copy link
Contributor

@happyume Congratulations! The deployment of your connector and documentation page is now complete, We have a short survey on the connector certification process that we would like for you to complete. Your feedback is appreciated and will help us improve the program, Thanks.

@sriyen-msft sriyen-msft merged commit e0cae34 into microsoft:dev Jun 15, 2022
lindarecfut pushed a commit to recordedfuture/PowerPlatformConnectors that referenced this pull request Feb 14, 2023
* Create readme.md

* RegEx Matching (Independent Publisher)

Uploaded apiProperties.json and apiDefinition.swagger.json

* Update readme.md

Added section for limitations and exclusions

* Update apiDefinition.swagger.json

Added new actions

* Screenshot files added from Power Automate

Added five screenshot files from Power Automate using this connector.

* Add screenshot files upload

* Screenshot from test operations

Screenshot from Test operations section of custom connector UI

* Update apiDefinition.swagger.json

Removed starting whitespace from propertyValue for Category and changed description of 200 response to "request processed OK"

* Update readme.md

Added section on obtaining credentials and general formatting

* Added new directory

* Add files via upload

Added images in its own directory

* Delete Screenshot_RegEx_ActionList.PNG

File has been re-uploaded to a sub-directory

* Delete .gitkeep

* Delete Screenshot_RegEx_CreateFlow_001.PNG

File has been re-uploaded to a sub-directory

* Delete Screenshot_RegEx_CreateFlow_002.PNG

File has been re-uploaded to a sub-directory

* Delete Screenshot_RegEx_CreateFlow_003.PNG

File has been re-uploaded to a sub-directory

* Delete Screenshot_RegEx_SuccessResult_001.PNG

File has been re-uploaded to a sub-directory

* Delete Screenshot_RegEx_SuccessResult_002.PNG

File has been re-uploaded to a sub-directory

* Delete Screenshot_RegEx_SuccessResult_003.PNG

File has been re-uploaded to a sub-directory

* Delete Screenshot_RegEx_TestCLI.PNG

File has been re-uploaded to a sub-directory

* Update readme.md

Updated to match the template

* Delete independent-publisher-connectors/Proposal - RegEx Matching (Independent Publisher)/Images directory

* Create readme.md

* Create apiProperties.json

* Create apiDefinition.swagger.json

* Delete independent-publisher-connectors/Proposal - RegEx Matching (Independent Publisher) directory

* Create readme.md

* Create apiProperties.json

* Create apiDefinition.swagger.json

* Delete independent-publisher-connectors/RegEx Matching (Independent Publisher) directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployed independent-publisher-connector New For brand new connector submissions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants