- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.4k
FactSet Patch - May 26 #1690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FactSet Patch - May 26 #1690
Conversation
Add files via upload
Modifying the apiProperties to remove sensitive information.
Update apiProperties.json to remove client ID
| Hi @krithsai! Thank you very much for submitting a new PR! Unfortunately, you have already submitted a PR before, we need to choose which one is going to be review, this one or the first one, but I guess it doesn't contain the latest changes. Please let us know which one is better for you! Please let me know if you have any questions. | 
| 
 @v-EgorKozhadei - Ah, my bad. We can use this PR for the purpose of review since you're right that the previous one doesn't have all the changes. Please go ahead and close the old PR. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @krithsai! Please check the comments after the review, thank you!
| Hello @krithsai, I hope you are doing well. Congratulations, your pull request is approved and merged. Please submit the files to ISV Studio using your latest commit id, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio. Please Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector. We expect all tests to be completed within 1-2 weeks. If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions. Please let me know if you have any questions. Thank you very much for working with us. | 
| Thanks for the update @v-EgorKozhadei. I will go ahead and submit to ISV Studio. You mentioned latest commit ID - is this one of these two IDs on the right side of the screenshot? | 
| @krithsai yes, the last one is about modifying the readme file. You can also see the commit history by clicking on "Commits" tab in this PR. The one at the bottom of that page will be the latest. Please let me know if you have any questions or need help! | 
* Add files via upload * Update apiProperties.json Modifying the apiProperties to remove sensitive information. * Making changes per msft feedback * Making changes per PR feedback * Modifying the readme file per template.

Making changes per feedback
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json, by runningpaconn validatecommand.apiProperties.jsonhas a valid brand color and doesn't use an invalid brand color,#007ee5or#ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: