Skip to content

Conversation

@krithsai
Copy link
Contributor

Making changes per feedback

  1. Removed empty operations
  2. Corrected description values
  3. Removed icon and settings files

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

krithsai and others added 5 commits May 10, 2022 15:07
Modifying the apiProperties to remove sensitive information.
Update apiProperties.json to remove client ID
@krithsai krithsai requested a review from a team as a code owner May 26, 2022 17:53
@v-EgorKozhadei v-EgorKozhadei added certified-connector New For brand new connector submissions labels May 27, 2022
@v-EgorKozhadei
Copy link
Contributor

Hi @krithsai!

Thank you very much for submitting a new PR!

Unfortunately, you have already submitted a PR before, we need to choose which one is going to be review, this one or the first one, but I guess it doesn't contain the latest changes.

Please let us know which one is better for you!
You can close the PR that won't be reviewed or we can close it for you.

Please let me know if you have any questions.

@natalie-pienkowska natalie-pienkowska removed the New For brand new connector submissions label May 27, 2022
@krithsai
Copy link
Contributor Author

krithsai commented Jun 1, 2022

Hi @krithsai!

Thank you very much for submitting a new PR!

Unfortunately, you have already submitted a PR before, we need to choose which one is going to be review, this one or the first one, but I guess it doesn't contain the latest changes.

Please let us know which one is better for you! You can close the PR that won't be reviewed or we can close it for you.

Please let me know if you have any questions.

@v-EgorKozhadei - Ah, my bad. We can use this PR for the purpose of review since you're right that the previous one doesn't have all the changes. Please go ahead and close the old PR.

@v-EgorKozhadei v-EgorKozhadei added the New For brand new connector submissions label Jun 1, 2022
@v-EgorKozhadei v-EgorKozhadei mentioned this pull request Jun 1, 2022
9 tasks
@v-EgorKozhadei v-EgorKozhadei added the Validation phase Connector is being validated by Microsoft. label Jun 3, 2022
Copy link
Contributor

@v-EgorKozhadei v-EgorKozhadei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @krithsai! Please check the comments after the review, thank you!

@v-EgorKozhadei v-EgorKozhadei removed the Validation phase Connector is being validated by Microsoft. label Jun 7, 2022
@v-EgorKozhadei
Copy link
Contributor

Hello @krithsai,

I hope you are doing well.

Congratulations, your pull request is approved and merged. Please submit the files to ISV Studio using your latest commit id, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio.

Please Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector.

We expect all tests to be completed within 1-2 weeks.

If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions.

Please let me know if you have any questions.

Thank you very much for working with us.

@v-EgorKozhadei v-EgorKozhadei merged commit c54ba56 into microsoft:dev Jun 7, 2022
@krithsai
Copy link
Contributor Author

krithsai commented Jun 7, 2022

Thanks for the update @v-EgorKozhadei. I will go ahead and submit to ISV Studio. You mentioned latest commit ID - is this one of these two IDs on the right side of the screenshot?

image

@v-EgorKozhadei
Copy link
Contributor

@krithsai yes, the last one is about modifying the readme file.

You can also see the commit history by clicking on "Commits" tab in this PR. The one at the bottom of that page will be the latest.

Please let me know if you have any questions or need help!

lindarecfut pushed a commit to recordedfuture/PowerPlatformConnectors that referenced this pull request Feb 14, 2023
* Add files via upload

* Update apiProperties.json

Modifying the apiProperties to remove sensitive information.

* Making changes per msft feedback

* Making changes per PR feedback

* Modifying the readme file per template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

certified-connector New For brand new connector submissions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants