-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create custom connector TrueDialog #1337
Conversation
"post": { | ||
"responses": { | ||
"201": { | ||
"description": "Incoming messages callback created" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TrueDialogDynamics Can you please let us know if this post action has schema definition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sriyen-msft Added schema for all the responses in this commit
"put": { | ||
"responses": { | ||
"201": { | ||
"description": "Keyword callback created" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TrueDialogDynamics Empty response schema is not allowed anymore, which means no dynamic content will be shown in the output and makers have to use parse JSON to parse the response. Please provide a valid response schema definition for all the operations in the swagger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added schema for all the responses in this commit
"put": { | ||
"responses": { | ||
"201": { | ||
"description": "Stop callback created" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TrueDialogDynamics Empty response schema is not allowed anymore, which means no dynamic content will be shown in the output and makers have to use parse JSON to parse the response. Please provide a valid response schema definition for all the operations in the swagger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added schema for all the responses in this commit
}, | ||
"CallbackToken": { | ||
"type": "string", | ||
"description": "CallbackToken" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TrueDialogDynamics All the description values of properties are expected to be free from grammatical and spell errors. Please provide valid description values.
Docs - Define operation and parameter summaries and descriptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed descriptions in this commit
"put": { | ||
"responses": { | ||
"201": { | ||
"description": "Delivery Notice callback created" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TrueDialogDynamics Empty response schema is not allowed anymore, which means no dynamic content will be shown in the output and makers have to use parse JSON to parse the response. Please provide a valid response schema definition for all the operations in the swagger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added schema for all the responses in this commit
"put": { | ||
"responses": { | ||
"201": { | ||
"description": "Invalid Targets callback created" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TrueDialogDynamics Empty response schema is not allowed anymore, which means no dynamic content will be shown in the output and makers have to use parse JSON to parse the response. Please provide a valid response schema definition for all the operations in the swagger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added schema for all the responses in this commit
TrueDialog's SMS API is enterprise-grade with more pre-built features than any other SMS software. Built for developers and hosted in the Microsoft Azure cloud, our SMS API is highly reliable, secure and includes a pre-built ISO 9001 database for extra opt-out and compliance protection. Also available through our full-featured Enterprise-Grade SMS Texting Software. | ||
|
||
[Learn more](https://www.truedialog.com/sms-api-texting-api/) about what sets TrueDialog’s API apart from the rest. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TrueDialogDynamics Please go thru the template provided for readme.md and add any required sections you are missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated readme file according to the provided template in this commit
Make changes according to the template file
Hi @TrueDialogDynamics! Our certification engineer, Srikanth, is currently on emergency leave. Please expect a delay with your PR. He will return January 31st, 2022. We apologize for any inconveniences. |
@TrueDialogDynamics Sorry for the delay in response, Your connector pull request is approved and merged, you can submit your connector artifacts to the Connector certification tab in ISV Studio to move forward in the certification process, Thanks. |
* Initial upload * Fix iconBrandColor * Update readme.md * Add stackOwner to apiProperties.json * Fix empty titles * Add schema definition for callbacks * Update description values of properties * Update readme.md Make changes according to the template file Co-authored-by: apoplutin <apoplutin@foundationmedicine.com>
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: