Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom connector TrueDialog #1337

Merged
merged 9 commits into from
Feb 8, 2022
Merged

Conversation

TrueDialogDynamics
Copy link
Contributor

@TrueDialogDynamics TrueDialogDynamics commented Dec 17, 2021

  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@TrueDialogDynamics TrueDialogDynamics requested a review from a team as a code owner December 17, 2021 18:10
@ghost
Copy link

ghost commented Dec 17, 2021

CLA assistant check
All CLA requirements met.

"post": {
"responses": {
"201": {
"description": "Incoming messages callback created"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrueDialogDynamics Can you please let us know if this post action has schema definition?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sriyen-msft Added schema for all the responses in this commit

"put": {
"responses": {
"201": {
"description": "Keyword callback created"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrueDialogDynamics Empty response schema is not allowed anymore, which means no dynamic content will be shown in the output and makers have to use parse JSON to parse the response. Please provide a valid response schema definition for all the operations in the swagger.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added schema for all the responses in this commit

"put": {
"responses": {
"201": {
"description": "Stop callback created"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrueDialogDynamics Empty response schema is not allowed anymore, which means no dynamic content will be shown in the output and makers have to use parse JSON to parse the response. Please provide a valid response schema definition for all the operations in the swagger.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added schema for all the responses in this commit

},
"CallbackToken": {
"type": "string",
"description": "CallbackToken"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrueDialogDynamics All the description values of properties are expected to be free from grammatical and spell errors. Please provide valid description values.
Docs - Define operation and parameter summaries and descriptions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed descriptions in this commit

"put": {
"responses": {
"201": {
"description": "Delivery Notice callback created"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrueDialogDynamics Empty response schema is not allowed anymore, which means no dynamic content will be shown in the output and makers have to use parse JSON to parse the response. Please provide a valid response schema definition for all the operations in the swagger.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added schema for all the responses in this commit

"put": {
"responses": {
"201": {
"description": "Invalid Targets callback created"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrueDialogDynamics Empty response schema is not allowed anymore, which means no dynamic content will be shown in the output and makers have to use parse JSON to parse the response. Please provide a valid response schema definition for all the operations in the swagger.

Copy link
Contributor Author

@TrueDialogDynamics TrueDialogDynamics Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added schema for all the responses in this commit

TrueDialog's SMS API is enterprise-grade with more pre-built features than any other SMS software. Built for developers and hosted in the Microsoft Azure cloud, our SMS API is highly reliable, secure and includes a pre-built ISO 9001 database for extra opt-out and compliance protection. Also available through our full-featured Enterprise-Grade SMS Texting Software.

[Learn more](https://www.truedialog.com/sms-api-texting-api/) about what sets TrueDialog’s API apart from the rest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrueDialogDynamics Please go thru the template provided for readme.md and add any required sections you are missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated readme file according to the provided template in this commit

@sriyen-msft sriyen-msft added needs:partner-attention Validation phase Connector is being validated by Microsoft. labels Jan 11, 2022
@natalie-pienkowska
Copy link
Contributor

Hi @TrueDialogDynamics! Our certification engineer, Srikanth, is currently on emergency leave. Please expect a delay with your PR. He will return January 31st, 2022. We apologize for any inconveniences.

@sriyen-msft sriyen-msft merged commit a3e103e into microsoft:dev Feb 8, 2022
@sriyen-msft sriyen-msft removed Validation phase Connector is being validated by Microsoft. needs:partner-attention labels Feb 8, 2022
@sriyen-msft
Copy link
Contributor

@TrueDialogDynamics Sorry for the delay in response, Your connector pull request is approved and merged, you can submit your connector artifacts to the Connector certification tab in ISV Studio to move forward in the certification process, Thanks.

ghost pushed a commit to recordedfuture/PowerPlatformConnectors that referenced this pull request Mar 28, 2022
* Initial upload

* Fix iconBrandColor

* Update readme.md

* Add stackOwner to apiProperties.json

* Fix empty titles

* Add schema definition for callbacks

* Update description values of properties

* Update readme.md

Make changes according to the template file

Co-authored-by: apoplutin <apoplutin@foundationmedicine.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants