Skip to content

Conversation

0xced
Copy link

@0xced 0xced commented Oct 13, 2022

Assign the result of parsing the "Integrated Security" setting to the DataverseConnectionStringProcessor.UseCurrentUser property. The "Integrated Security" part was parsed but the result was not used and the UseCurrentUser existed but was never assigned. I'm pretty sure that it was intended to be like this, especially with the comment above parsing of the IntegratedSecurity:

// Check to see if use current user is configured.

Assign the result of parsing the "Integrated Security" setting to the `DataverseConnectionStringProcessor.UseCurrentUser` property. The "Integrated Security" part was parsed but the result was not used and the `UseCurrentUser` existed but was never assigned. I'm pretty sure that it was intended to be like this, especially with the comment above parsing of the IntegratedSecurity:
> // Check to see if use current user is configured.
@MattB-msft
Copy link
Member

You are correct @0xced that is a bug.
we are going to accept this PR into our main release branch and close it when we push the next update.

Thanks for your continued support!

MattB-msft added a commit that referenced this pull request Nov 4, 2022
Fix by Git user matkov accepted for crash during create when an invalid timespan is passed from a configuration file to the ServiceClient Constructor. See #326 for details.
Fix by GIT user 0xced accepted for bug in Integrated user security setting,  Code will now properly honor integrated security when attempting to authenticate. See #324 for details.
Fixed a number of places where Async Calls did not have a .ConfigureAwait specification. Thanks to user 0xced for prompting this fix.
Fixed a misleading warning message "Client ID not supplied, using SDK Sample Client ID for this connection" that would be incorrectly shown when ExternalAuthentication type was used. Fixes #314, Thanks for your report!
Fixed a possible thread contention issue when managing connection context across multiple concurrent threads in the same client.  Git issue: #304 Thanks for your report !
Fixed a memory leak when caused by a logger not being cleaned up when a the creation of the ServiceClient fails. Git issue: #322
Fixed issue where calling the IOrganizationService* interfaces after the client has been disposed would throw a NullReferenceException. Taking this action will now throw an ObjectDisposedException
Removed a set of exception catch and rethrows to preserve the full callstack to caller. Thanks to Git user 0xceed for prompting ( and sticking with getting us to ) this fix. See: #248 for details.
@0xced 0xced deleted the UseCurrentUser branch November 4, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants