Merged
Conversation
Add `powerbi.getSDKVersion` method In ISV scenario it is hard to find the SDK version in the dev tools so I am adding a method to return it.
Added owners.txt
Remove comments in OE: powerbi-javascript
hosting apps (like TypeScript) that creates a double instance of `service` will cause double registration for eventHooks listener which leads to miss the callback from the iframe. moving `router.post` from `service` constructor to `report` constructor resolves the issue.
For an unknown reason, 2.20.0 was released 2 weeks ago to internal feed although it was not triggered. This causes the internal feed phase to fail as package already existed.
release version 2.21.0, updating models version
sdkType tells us which SDK wrapper performs the actions, e.g: powerbi-client-react, powerbi-client-angular... To update it we should pass the type in the header 'x-sdk-type` which is populated in the service constructor. Therefore, each wrapper needs to pass the correct sdkType when initiating the service (see example: [Pull Request 274150](https://dev.azure.com/powerbi/Embedded/_git/powerbi-client-react/pullrequest/274150)). **What is the problem?** if user injects a new powerbi service to the wrapper and doesn't use the default service, the sdkType won't be populated. As a result, I created new API in the service, so we could update in each wrapper the sdk type after the service is created. In addition, create new header `x-sdk-wrapper-version`.
ghost
approved these changes
Jul 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.