Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4668 Incorrect version in vsix manifest #4673

Merged
merged 3 commits into from
Aug 21, 2018
Merged

Fixes #4668 Incorrect version in vsix manifest #4673

merged 3 commits into from
Aug 21, 2018

Conversation

zooba
Copy link
Member

@zooba zooba commented Aug 21, 2018

Fixes #4668 Incorrect version in vsix manifest
Fixes version numbers.

huguesv
huguesv suggested changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@huguesv huguesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's two 10.0 that should be 17.0

Python/Product/Cookiecutter/source.extension.vsixmanifest Outdated
@@ -10,13 +10,13 @@
<PreviewImage>Resources\CookiecutterTemplate_200x.png</PreviewImage>
</Metadata>
<Installation SystemComponent="true" AllUsers="true" InstalledByMsi="true">
<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[15.0,16.0)" />
<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[16.0,10.0)" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[16.0,17.0)

Python/Product/IronPython/source.extension.vsixmanifest Outdated
@@ -10,14 +10,14 @@
<PreviewImage>PythonProjectBig.ico</PreviewImage>
</Metadata>
<Installation SystemComponent="true" AllUsers="true" InstalledByMsi="true">
<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[15.0,16.0)" />
<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[16.0,10.0)" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[16.0,17.0)

@zooba zooba merged commit ad5b92e into microsoft:master Aug 21, 2018
@zooba zooba deleted the issue-4668 branch August 21, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huguesv huguesv huguesv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zooba @huguesv