Fix to properly assign schemas to content of all media types of all r… #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2019
PerthCharern
suggested changes
Apr 11, 2019
src/Microsoft.OpenApi.Readers/V2/OpenApiResponseDeserializer.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.OpenApi.Readers.Tests/Microsoft.OpenApi.Readers.Tests.csproj
Outdated
Show resolved
Hide resolved
PerthCharern
approved these changes
Apr 15, 2019
test/Microsoft.OpenApi.Readers.Tests/V2Tests/Samples/twoResponses.json
Outdated
Show resolved
Hide resolved
|
Thanks for the contribution @VitaliyKurokhtin. I'll check this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is an error to clean temp schema storage after processing single "produces" item since it's per response. Thus moving it outside by cleaning it only if there are any "produces" items to accomodate for scenario when "produces" is specified after "paths"