Fix issue Empty tag causes error generating Kiota client #2283 #2286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanCuypers
requested review from
irvinesunday,
darrelmiller,
gavinbarron,
millicentachieng,
MaggieKimani1 and
baywet
as code owners
|
@microsoft-github-policy-service agree |
|
Hi @StefanCuypers, thank you for your contribution! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
baywet
requested changes
Mar 27, 2025
There was a problem hiding this comment.
Thanks for the contribution!
Here are a couple of recommendations.
@MaggieKimani1 don't worry about the conventional commits just yet, we'll squash merge and amend the commit message as we do so
src/Microsoft.OpenApi/Reader/V2/OpenApiOperationDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi/Reader/V2/OpenApiOperationDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi/Reader/V2/OpenApiOperationDeserializer.cs
Outdated
Show resolved
Hide resolved
baywet
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing the list of tags, removed tags that are empty so we don't fail on them.