Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DataTypeMismatch validation rule from the default ruleset #1888

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Remove DataTypeMismatch validation rule from the default ruleset #1888

merged 7 commits into from
Oct 29, 2024

Conversation

MaggieKimani1
Copy link
Contributor

@MaggieKimani1 MaggieKimani1 commented Oct 23, 2024 •
edited
Loading

andrueastman
andrueastman reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, do we want the rule completely removed from the code?
Or do we want the rule to not be in the default set of rules (meaning a caller of the library could opt in to it if they so wished)?

@MaggieKimani1
Copy link
Contributor Author

MaggieKimani1 commented Oct 24, 2024 •
edited
Loading

Out of curiosity, do we want the rule completely removed from the code? Or do we want the rule to not be in the default set of rules (meaning a caller of the library could opt in to it if they so wished)?

Oh actually yes, the intent is to remove it from the default ruleset and allow users to opt in. Let me correct that.

@MaggieKimani1 MaggieKimani1 changed the title Remove DataTypeMismatch validation rule Remove DataTypeMismatch validation rule from the default ruleset Oct 24, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MaggieKimani1 MaggieKimani1 linked an issue Oct 24, 2024 that may be closed by this pull request
ValidateDataTypeMismatch is failing to parse examples #1879
Closed
@MaggieKimani1 MaggieKimani1 merged commit 34b81ce into release/2.0.0 Oct 29, 2024
8 checks passed
@MaggieKimani1 MaggieKimani1 deleted the mk/remove-validation-rule branch October 29, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman left review comments

@darrelmiller darrelmiller darrelmiller approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@gavinbarron gavinbarron Awaiting requested review from gavinbarron

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValidateDataTypeMismatch is failing to parse examples
3 participants
@MaggieKimani1 @darrelmiller @andrueastman