Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove validation rule to make paths and webhooks optional #1856

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Remove validation rule to make paths and webhooks optional #1856

merged 1 commit into from
Oct 8, 2024

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1855

@MaggieKimani1 MaggieKimani1 linked an issue Oct 3, 2024 that may be closed by this pull request
The rule that paths or webhooks is required is not consistent with the specification #1855
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MaggieKimani1 MaggieKimani1 merged commit 23fde05 into release/2.0.0 Oct 8, 2024
9 checks passed
@MaggieKimani1 MaggieKimani1 deleted the mk/make-update-validation-rule branch October 8, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrelmiller darrelmiller darrelmiller approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The rule that paths or webhooks is required is not consistent with the specification
2 participants
@MaggieKimani1 @darrelmiller