Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/3 0 4 #1823

Merged
merged 3 commits into from
Nov 12, 2024
Merged

feature/3 0 4 #1823

merged 3 commits into from
Nov 12, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Sep 5, 2024 •
edited
Loading

OAS 3.0.4 is on the almost here! https://github.com/OAI/OpenAPI-Specification/milestone/16
OAI/OpenAPI-Specification#4080
This PR:

  • bumps the emitted version when serializing OAS descriptions.
  • ajusts how types are handled for integer since it's technically not a valid type.

Holding until the version officially comes out.

@baywet baywet self-assigned this Sep 5, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76.9% Coverage on New Code (required ≥ 80%)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@baywet
Copy link
Member Author

baywet commented Sep 12, 2024

depends on OAI/OpenAPI-Specification#4080

@baywet
feat: bumps v3 patch version to 3.0.4
ce64230 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet marked this pull request as ready for review October 24, 2024 16:41
@baywet baywet enabled auto-merge October 24, 2024 16:41
@baywet
Merge branch 'vnext' into feature/3-0-4
39d8c29 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: failing unit test after merge
a4ac872 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet merged commit 9af3731 into vnext Nov 12, 2024
8 of 10 checks passed
@baywet baywet deleted the feature/3-0-4 branch November 12, 2024 10:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaggieKimani1 MaggieKimani1 MaggieKimani1 approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday irvinesunday is a code owner

@darrelmiller darrelmiller Awaiting requested review from darrelmiller darrelmiller is a code owner

@gavinbarron gavinbarron Awaiting requested review from gavinbarron gavinbarron is a code owner

@millicentachieng millicentachieng Awaiting requested review from millicentachieng millicentachieng is a code owner

@andrueastman andrueastman Awaiting requested review from andrueastman andrueastman is a code owner

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baywet @MaggieKimani1