Closed
Conversation
Contributor
|
Thanks Darrel.
|
Member
Author
|
@PerthCharern I'm not really happy with the solution, but every other alternative that I have considered so far seems worse! |
Contributor
Member
Author
|
@PerthCharern Yes. In fact I'm just going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a proposal for potentially implementing strongly typed custom extensions. I have introduced a new interface IOpenApiExtension which IOpenApiAny now implements so it does still work as it did before. However, you can now also create custom classes for those extensions.
Currently the custom classes need to deserialize from an IOpenApiAny instance, but this might not be the best approach. I was going to make them deserialize from ParseNode but that would require making that set of classes public, which I'm not too sure we want to do.
I also want to make sure we can use the validation rules to validate these custom extensions. That's the next thing I want to try. But in the meanwhile, if I can get some feedback on the approach so far and your feeling about parsing from ParseNode vs OpenApiAny that would be great.