Skip to content

Add reusable path items to components object #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Nov 3, 2022
Merged

Add reusable path items to components object #1056

merged 39 commits into from
Nov 3, 2022

Conversation

@MaggieKimani1
Copy link
Contributor

@MaggieKimani1 MaggieKimani1 commented Oct 31, 2022

This PR:

  • Adds a PathItems property to the Components object that contains paths that can be reused in Webhooks by using a $ref pointer
  • Adds logic to resolve the reference pointer to the reusable pathItem
  • Adds a test to validate this

@MaggieKimani1
Add webhooks property to OpenAPI document
f6cc9d8
@MaggieKimani1
Deep copy the webhooks object in the copy constructor
0678365
@MaggieKimani1
Add serialization for the webhooks property
5bb8f44
@MaggieKimani1
Add logic to deserialize the webhooks property
7479780
@MaggieKimani1
Clean up project references
43e165c
@MaggieKimani1
Add pathItem reference type and webhooks constant
9efc130
@MaggieKimani1
Add pathItems object to component object
094a980
@MaggieKimani1
Add serialization tests for both Yaml and Json
59fbec8
@MaggieKimani1
Adds tests
c79a4f9
@MaggieKimani1
Adds 3.1 as a valid input OpenAPI version
103f123
@MaggieKimani1
Adds a walker to visit the webhooks object and its child elements
624bd0c
@MaggieKimani1
Update the validation rule to exclude paths as a required field accor…
7a14575 
…ding to the 3.1 spec
@MaggieKimani1
Revert change
8d004ff
@MaggieKimani1
Merge branch 'mk/add-webhooks-property' into mk/add-pathItems-to-comp…
661bd1a 
…onents-object
@MaggieKimani1
Update test with correct property type
149175c
@MaggieKimani1
Add the validation for Paths as a required field in 3.0 during parsing
17b1c2d
@MaggieKimani1
Update spec version
c79bd11
@MaggieKimani1
Merge branch 'mk/add-webhooks-property' into mk/add-pathItems-to-comp…
7f30fdf 
…onents-object
@MaggieKimani1
Add more validation for empty paths and missing paths/webhooks for 3.1
b7e3e48
@MaggieKimani1
Merge branch 'mk/add-webhooks-property' into mk/add-pathItems-to-comp…
26c61d1 
…onents-object
@MaggieKimani1
Use Any() instead of count
846fb0e
@MaggieKimani1
Merge branch 'mk/add-webhooks-property' into mk/add-pathItems-to-comp…
01fefe9 
…onents-object
@MaggieKimani1
Code clean up
2299117
@MaggieKimani1
Add negation operator
21e19a0
@MaggieKimani1
Merge branch 'mk/add-webhooks-property' into mk/add-pathItems-to-comp…
7f14ba1 
…onents-object
@MaggieKimani1
Change reference type to pathItem
6152336
@MaggieKimani1
Merge branch 'mk/add-webhooks-property' into mk/add-pathItems-to-comp…
4901a65 
…onents-object
@MaggieKimani1
Reuse LoadPaths() logic to avoid creating a root reference object in …
86594a8 
…webhooks
@MaggieKimani1
Update test
243eb23
@MaggieKimani1
Merge branch 'mk/add-webhooks-property' into mk/add-pathItems-to-comp…
093f761 
…onents-object
@MaggieKimani1
Get the $ref pointer to a pathItem object and resolve the reference b…
7e77070 
…y returning the pathItem matching the reference Id in the components object
@MaggieKimani1
Clean up
cd392b7
@MaggieKimani1
Add test
4eb9a13
@MaggieKimani1 MaggieKimani1 mentioned this pull request Oct 31, 2022
Closed
11 tasks
baywet
baywet requested changes Oct 31, 2022
View reviewed changes
baywet
baywet requested changes Nov 1, 2022
View reviewed changes
@MaggieKimani1 MaggieKimani1 merged commit 3db2ffc into release/2.0.0 Nov 3, 2022
@MaggieKimani1 MaggieKimani1 deleted the mk/add-pathItems-to-components-object branch November 3, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaggieKimani1 @baywet