Skip to content

Adds action/function suffix to tag names for action/function operations #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

timayabi2020
Copy link
Contributor

Fixes #640
This PR is a follow up to #586 and it includes "Actions" or "Functions" as suffixes to the tag. This will

  • enable the powershell mappings to be updated to target the paths more precisely to fix the incorrect mappings.
  • enable the user functions/actions to still remain in their current modules by targeting operationIds like user.*.Actions.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test for that behaviour.
Also:

  • main is the branch for v2.x (currently in preview)
  • support/v1 is the branch for 1.X (GA, what our tooling uses)

You'll need to port the fix (cherry-pick, not merge) to benefit it in the generation pipeline

@timayabi2020
Copy link
Contributor Author

Closing this in favor of another PR that targets support/v1 branch

@baywet
Copy link
Member

baywet commented Jan 17, 2025

@timayabi2020 you'll need to do both so the fix is also present in v2 when we release and there are no regressions. (unless it's already present in 2.X)

@timayabi2020 timayabi2020 reopened this Jan 20, 2025
baywet
baywet previously approved these changes Jan 20, 2025
@baywet
Copy link
Member

baywet commented Jan 20, 2025

@timayabi2020 I think some of the changes around the Id were missed here.

Copy link

@timayabi2020 timayabi2020 merged commit ea589d3 into main Jan 20, 2025
15 checks passed
@timayabi2020 timayabi2020 deleted the tm/fix-operation-tag-names branch January 20, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming convention (NavigationSource.NavigationEntity) of tags targeting action/function operations causes incorrect Graph PowerShell module mappings
2 participants