Skip to content

Azure DevOps pipeline for releasing the library to nuget.org and github releases #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 17, 2022

Conversation

danielmbaluka
Copy link
Contributor

@danielmbaluka danielmbaluka commented Jan 20, 2022

Fixes #136

Changes in this PR

@danielmbaluka danielmbaluka force-pushed the feature/dm/automate-release-to-nuget-and-github branch 2 times, most recently from cc2134f to 6591925 Compare January 20, 2022 11:43
@danielmbaluka danielmbaluka changed the title Azure DevOps pipeline for releasing to Nuget and Github Azure DevOps pipeline for releasing the library to nuget.org and github releases Jan 24, 2022
@danielmbaluka danielmbaluka marked this pull request as ready for review January 24, 2022 06:29
@danielmbaluka
Copy link
Contributor Author

The pipeline is currently failing because of a key permission issue
Failed OperationId: 458d5fc7-d8a6-498d-b50f-653a5077485b, Status: FailDoNotRetry, FilePath:D:\a\1\s\bin\Release\net472\Microsoft.OpenApi.OData.Reader.dll, Error: {"code":"NeoSigningServiceFailedError","details":{"error":"An exception occurred in the NEO StaticSigner service.","exception":"This clientId *** is unauthorized to access MSSharedLibSnKey"},"innerError":null}
https://microsoftgraph.visualstudio.com/Graph%20Developer%20Experiences/_build/results?buildId=64223&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=094908eb-9b91-5864-e5bc-10e3f5697105

@danielmbaluka danielmbaluka requested a review from baywet January 25, 2022 05:45
@danielmbaluka danielmbaluka force-pushed the feature/dm/automate-release-to-nuget-and-github branch from 9af9ab0 to ce575e9 Compare February 3, 2022 12:35
@baywet
Copy link
Member

baywet commented Feb 3, 2022

The main workflow seems to be failing now because of a relative path issue.
adding workingDirectory: $(Build.SourcesDirectory)\src\Microsoft.OpenApi.OData.Reader\
under

projects: '$(Build.SourcesDirectory)\src\Microsoft.OpenApi.OData.Reader\Microsoft.OpenAPI.OData.Reader.csproj'

should fix that

more information

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see my previous comment)

@danielmbaluka danielmbaluka force-pushed the feature/dm/automate-release-to-nuget-and-github branch from 575d7f9 to 25cc8dd Compare February 8, 2022 12:54
@danielmbaluka
Copy link
Contributor Author

@xuzhg @darrelmiller I would appreciate your reviews on this PR. The significant change in this PR is using the newly generated SNK key for strong name signing. This replaces the shared "MSSharedLibSnKey" which required us to use do delay signing as the private key is only accessible by the Azure pipeline.

baywet
baywet previously approved these changes Feb 10, 2022
@baywet baywet added this to the 1.0.10 milestone Feb 10, 2022
@darrelmiller darrelmiller removed this from the 1.0.10 milestone Feb 10, 2022
@baywet
Copy link
Member

baywet commented Feb 16, 2022

@danielmbaluka ready to merge whenever you want. One gotcha @zengin and I noticed a while ago, when you update the triggers on the pipeline definition, it may not necessarily reflect the changes in ADO. You might have to manually reflect the changes on the build definition's settings.

@danielmbaluka danielmbaluka merged commit 6e96f51 into master Feb 17, 2022
@danielmbaluka danielmbaluka deleted the feature/dm/automate-release-to-nuget-and-github branch February 17, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated releasing to nuget
4 participants