Merged
Conversation
Collaborator
srinathsetty
commented
Mar 10, 2025
srinathsetty
commented
- Eliminate the need to specify a circuit on E2
- Eliminate the need to specify initial inputs on E2
- Update benchmarks and rest of code to use simplified APIs
milosdjurica
added a commit
to MVPWorkshop/Nova
that referenced
this pull request
Mar 13, 2025
* feat: add batch commit to trait (microsoft#366) * feat: add batch_commit and default implementation to CommitmentEngineTrait * feat: add batch_vartime_multiscalar_mul and default implementation to DlogGroup trait * feat: implement batch_commit in hyperkzg * fix: batch_commit should support using a slice of blinding factors * KZG Key Generation, Save, Load (microsoft#368) * save load * fixed exp batch * tools * fix * fix * fix * improve interface * clean * fix typos * fix * clean * ptau * ptau save load * fix * fix * pedersen save --------- Co-authored-by: Srinath Setty <srinath@microsoft.com> * An initial implementation of NeutronNova (microsoft#370) * simplify types * placeholder * deduplicate code an initial draft of running instance in neutronnova * test default instance-witness pair * simplify poseidon sponge * checkpoint NIFS prover * add verify * add padding in test case * additional progress * finish testing neutronnova folding scheme * small cleanup * factor out contributions from eq * reorganize code * checkpoint * change power polynomial * checkpoint * checkpoint working test * switch the order * checkpoint * compute the right E vectors * leverage the nested structure * simplify the handling of E1 and E2 * simplify the handling of E1 and E2 * simplify tests * test when the left and right split unevenly * rearrange * general code cleanup * fix clippy warnings * simplify Poseidon state reset; cleanup unused code * cleanup unused code * checkpoint circuits from Nova folding scheme * checkpoint and reorganize gadgets a bit * use the version from gadgets * create various low-level gadgets * fix most of the build issues * fix build issues * more progress on circuit * fix duplicate paths * use expect test * replace params with vk to avoid confusion * builds * tests build * additional checks * print failures * simplify the RO usage * fix tests * fix univariate * checkpoint * checkpoint nifs circuit * checkpoint * test passes * cargo check passes * revive tests * add missing file * cleanup; fix test * fix clippy * add missing constraints * simplify * move neutron under an experimental feature flag * remove unused file * remove unused file * save on field multiplications * Simplify Nova APIs (microsoft#373) * checkpoint simplified APIs * cleanup code * fix benches to use the simplified APIs * de-duplicate hash check code * fix clippy errors * bring back MSM from https://github.com/microsoft/Nova/blob/7050052bc2… (microsoft#375) * bring back MSM from https://github.com/microsoft/Nova/blob/7050052bc2606129fbb52a1fa666eef22d92748d/src/provider/msm.rs * fix tests * fixed to work in no_std too --------- Co-authored-by: Jacob Trombetta <jacob.trombetta@spaceandtime.io> Co-authored-by: SunJc <331631622@qq.com> Co-authored-by: Srinath Setty <srinath@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.