Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Rename lambda_ to l2_regularization in LinearSvmBinaryClasifier #259

Merged
merged 1 commit into from
Sep 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ class LinearSvmBinaryClassifier(

:param caching: Whether trainer should cache input training data.

:param lambda_: Regularizer constant.
:param l2_regularization: L2 regularization weight. It also controls the
learning rate, with the learning rate being inversely proportional to
it.

:param perform_projection: Perform projection to unit-ball? Typically used
with batch size > 1.
Expand Down Expand Up @@ -105,7 +107,7 @@ def __init__(
self,
normalize='Auto',
caching='Auto',
lambda_=0.001,
l2_regularization=0.001,
perform_projection=False,
number_of_iterations=1,
initial_weights_diameter=0.0,
Expand All @@ -119,7 +121,7 @@ def __init__(

self.normalize = normalize
self.caching = caching
self.lambda_ = lambda_
self.l2_regularization = l2_regularization
self.perform_projection = perform_projection
self.number_of_iterations = number_of_iterations
self.initial_weights_diameter = initial_weights_diameter
Expand All @@ -146,7 +148,7 @@ def _get_node(self, **all_args):
all_args),
normalize_features=self.normalize,
caching=self.caching,
lambda_=self.lambda_,
lambda_=self.l2_regularization,
perform_projection=self.perform_projection,
number_of_iterations=self.number_of_iterations,
initial_weights_diameter=self.initial_weights_diameter,
Expand Down
8 changes: 5 additions & 3 deletions src/python/nimbusml/linear_model/linearsvmbinaryclassifier.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ class LinearSvmBinaryClassifier(

:param caching: Whether trainer should cache input training data.

:param lambda_: Regularizer constant.
:param l2_regularization: L2 regularization weight. It also controls the
learning rate, with the learning rate being inversely proportional to
it.

:param perform_projection: Perform projection to unit-ball? Typically used
with batch size > 1.
Expand Down Expand Up @@ -114,7 +116,7 @@ def __init__(
self,
normalize='Auto',
caching='Auto',
lambda_=0.001,
l2_regularization=0.001,
perform_projection=False,
number_of_iterations=1,
initial_weights_diameter=0.0,
Expand Down Expand Up @@ -147,7 +149,7 @@ def __init__(
self,
normalize=normalize,
caching=caching,
lambda_=lambda_,
l2_regularization=l2_regularization,
perform_projection=perform_projection,
number_of_iterations=number_of_iterations,
initial_weights_diameter=initial_weights_diameter,
Expand Down
9 changes: 8 additions & 1 deletion src/python/tools/manifest_diff.json
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,14 @@
"Module": "linear_model",
"Type": "Classifier",
"Predict_Proba" : true,
"Decision_Function" : true
"Decision_Function" : true,
"Inputs": [
{
"Name": "Lambda",
"NewName": "l2_regularization",
"Desc": "L2 regularization weight. It also controls the learning rate, with the learning rate being inversely proportional to it."
}
]
},
{
"Name": "Trainers.EnsembleClassification",
Expand Down