This repository was archived by the owner on Nov 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
Add azureml-dataprep support for dataflow objects #181
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
cb4ef04
draft code
ganik 538fb9d
draft
ganik f574f51
delete
ganik 354a1dc
add dprep dependency
ganik 6ac4986
rollback
ganik 00daceb
rollback
ganik be91812
rollback
ganik 171cd53
test & example on using DprepDataStream
ganik 61c6bcb
add dprep path
ganik 6a90fee
add dprep path
ganik c411548
fix mlnetpath
ganik 147a3b9
optional dependency on dprep
ganik ff21578
run dprep tests optionally
ganik ad642cb
fix typo
ganik 89e3470
Up sdk version
ganik 21d980f
fix linux dprep tests
ganik bdb2ab8
Merge branch 'master' into ganik/dprep1
ganik 72b9b61
Merge branch 'master' into ganik/dprep1
ganik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems wrong. Why is the DataPrep directory considered the
APP_PATHS
? Shouldn't it just instead be added totpaList
? #ResolvedUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DataPrep folder contains numerous dlls for azureml-dataprep package to run. Not all of them needed for in process integration that NimbusML doing here. Also many of dlls are duplicates of dotnetcore2 package (.NET Core CLR runtime). Putting DataPrep dlls on TPAList will
I want to avoid this and use only dotnetcore2, ML.NET, Microsoft.DataPrep.* and Microsoft.DPrep.* dlls - these are put into TPA list. If for some reason I missed any of dlls that DPrep needs I have set probing path to Dprep folder.
In reply to: 302699171 [](ancestors = 302699171)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we treating the ML.NET and the DataPrep libraries differently? Maybe we should just put both locations on the
APP_PATHS
.That way, when the next library comes along that we need to do this for, it is obvious to just add it to
APP_PATHS
. #ResolvedUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, next library will go same way as Dprep into APP_PATHS. Reasons I treat ML.NET and DataPrep differently bcs:
Another issue: there are mismatches in versions of *Dprep.dlls that are exposed in NuGet and installed with azureml-dataprep package. During testing I found out that I need to keep the versions of *Dprep.dll that I built against but for the rest of supporting dlls I can point to Dprep folder. We will have to do further testing to figure out correct versions of azureml-dataprep to be installed to work with built ones in NimbusML. Now it seems that latest azureml-dataprep package works.
In reply to: 302984801 [](ancestors = 302984801)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading https://docs.microsoft.com/en-us/dotnet/core/tutorials/netcore-hosting#step-3---prepare-runtime-properties, and talking with a CoreCLR dev, the recommendation here is to use the
TRUSTED_PLATFORM_ASSEMBLIES
for all the assemblies. From the doc:I don't want to block you going this route, since I haven't really worked in NimbusML, but I just figured I'd give you as much information as possible to make an informed decision. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you Eric!
In reply to: 303107371 [](ancestors = 303107371)